perf+refactor: read-model layer — single-statement writes, static schemas, one table vocabulary

[patrickleet]

Summary

Six commits, one per audit finding, ordered highest-impact first:

1. perf: single-statement row writes (1e6b6e9) — ExpectedVersion::Any upserts now run one INSERT ... ON CONFLICT (pk) DO UPDATE SET ..., version = version + 1 instead of SELECT-then-UPDATE-or-INSERT inside the aggregate commit transaction (~2 fewer round trips per read-model row). Patches/deletes fold the version bump into SET and the expected version into WHERE, re-reading only on a miss to distinguish not-found from a version conflict. NotExists keeps the read-then-write shape. (Postgres gotcha handled: unqualified column refs in DO UPDATE SET RHS are ambiguous with excluded; the existing-row reference is table-qualified.)
2. perf: static schemas (1aebabf) — the derive emits fn schema() -> &'static TableSchema backed by LazyLock; mutation types hold &'static TableSchema instead of an owned clone per staged mutation. RelationalReadModelIncludes gains a generated include_target_schema so workspace baselines track static schemas for relationship targets too.
3. perf: precomputed sort keys (fb079bd) — into_write_plan no longer formats two Strings per comparison.
4. refactor: session.rs split (2779874) — the 1,507-line file (no Session type) becomes capabilities.rs, load.rs, plan.rs, workspace.rs (+ mutations, which land in table/); public paths preserved via read_model/mod.rs re-exports.
5. refactor!: one table vocabulary (a367996) — the 24-alias sheet in src/table/mod.rs is deleted. Neutral primitives (schema/metadata types, row mutations + validation, write plans, registry/adapter surface, the error) move into table/ under their canonical names (TableSchema, TableStoreError, TableColumn, TableRowMutation, TableWritePlan, ...); read_model builds on them and keeps only its own surface (traits, builder, loads, workspace, in-memory store). Renames applied across src, tests, and the derive macro's emitted paths; error display text and table-path messages are neutral now.
6. fix: no .expect() in bootstrap ordering (e06cf12) — table_schemas_in_dependency_order keeps schemas in the working map, so the two panicking lookups disappear.

Test output

cargo test --workspace --all-features --all-targets (sqlite + postgres suites, DATABASE_URL on the dedicated review_rm db): 45 test binaries, 0 failures, including read_model_session (292 lib tests), read_model_relationship_includes, read_model_metadata, read_model_schema_bootstrap, distributed_read_model, distributed_read_model_board, read_model_commit_bridge, and both repository/conformance suites.

cargo clippy --workspace --all-features --all-targets clean (the only two warnings are pre-existing in untouched files: tests/todos MutexGuard-across-await, outbox_worker manual_async_fn).

Breaking changes

Commit 5 is a crate-wide rename (pre-release, no aliases or shims left behind): ReadModelError→TableStoreError, ReadModelSchema→TableSchema, ColumnDef→TableColumn, IndexDef→TableIndex, RowMutation→TableRowMutation, ReadModelWritePlan→TableWritePlan, etc. RelationalReadModel::schema() and TableModel::table_schema() now return &'static TableSchema.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DzYSVLas93c7LbgHJWsW7n

[coderabbitai]

Warning

Review limit reached

@patrickleet, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 53d73cfa-3f9a-49db-94ba-4c4421991a91

📥 Commits

Reviewing files that changed from the base of the PR and between 5b79222 and 53fc0c5.

📒 Files selected for processing (40)

• distributed_macros/src/read_model.rs
• src/commit_builder/mod.rs
• src/hashmap_repo/repository.rs
• src/lib.rs
• src/manifest.rs
• src/outbox/commit.rs
• src/outbox/table.rs
• src/postgres_repo/mod.rs
• src/queued_repo/repository.rs
• src/read_model/capabilities.rs
• src/read_model/in_memory.rs
• src/read_model/load.rs
• src/read_model/mod.rs
• src/read_model/plan.rs
• src/read_model/session.rs
• src/read_model/workspace.rs
• src/repository/error.rs
• src/repository/traits.rs
• src/sqlite_repo/mod.rs
• src/sqlx_repo/mod.rs
• src/sqlx_repo/read_model.rs
• src/table/error.rs
• src/table/metadata.rs
• src/table/mod.rs
• src/table/mutation.rs
• src/table/plan.rs
• src/table/registry.rs
• src/table/sql.rs
• tests/distributed_read_model/main.rs
• tests/distributed_read_model/projection_service/handlers/mod.rs
• tests/distributed_read_model/query_service/mod.rs
• tests/distributed_read_model/read_models/mod.rs
• tests/distributed_read_model_board/projections_service/mod.rs
• tests/distributed_read_model_board/query_service/mod.rs
• tests/distributed_read_model_board/read_models/mod.rs
• tests/read_model_metadata/main.rs
• tests/read_model_relationship_includes/main.rs
• tests/read_model_schema_bootstrap/main.rs
• tests/read_model_session/main.rs
• tests/sqlite_repository/main.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch review/read-model-perf-structure

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}