Skip to content

chore: standardize distributed CLI naming - #188

Merged
patrickleet merged 1 commit into
mainfrom
chore/distributed-cli-naming-cleanup
Aug 16, 2026
Merged

patrickleet merged 1 commit into
mainfrom
chore/distributed-cli-naming-cleanup

Conversation

@patrickleet

@patrickleet patrickleet commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace stale dctl references in code comments, test helper names, fixtures, and the GraphQL dry-run script with distributed.
  • Keep the internal distributed_cli crate name unchanged; it is not the user-facing executable name.
  • Preserve historical KB task evidence while updating current KB context/specs and documenting dctl as superseded.
  • No compatibility alias is added.

Validation

  • cargo test -p distributed_cli --test cli_client --test cli_skills_init
  • npm run build in js/
  • node --test tests/sveltekit-vite.test.mjs in js/
  • git diff --check

cargo fmt --all -- --check still reports pre-existing repository-wide formatting drift; no formatter changes are included.

Summary by CodeRabbit

  • Documentation

    • Updated CLI references throughout GraphQL, schema, and project documentation to use the distributed CLI terminology.
    • Clarified development and client-generation instructions, including committed generated clients and build behavior.
  • Tests

    • Renamed test helpers and fixtures to consistently reflect the distributed CLI.
    • Test commands and behavior remain unchanged.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ac052980-b9e1-4f8c-a739-5ce3af7eba17

📥 Commits

Reviewing files that changed from the base of the PR and between b97f96a and 922f270.

📒 Files selected for processing (13)
  • distributed_cli/tests/cli_client.rs
  • distributed_cli/tests/cli_skills_init.rs
  • js/tests/sveltekit-vite.test.mjs
  • scripts/graphql-skill-dry-run.sh
  • src/graphql/client_manifest/codec.rs
  • src/graphql/client_manifest/mod.rs
  • src/graphql/mod.rs
  • src/graphql/sdl.rs
  • src/graphql/surface/application.rs
  • src/graphql/surface/mod.rs
  • src/lib.rs
  • tests/e2e-ui/ui/.gitops/deploy/values.yaml
  • tests/e2e-ui/ui/vite.config.ts

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change replaces remaining dctl references with distributed naming across CLI tests, scripts, fixtures, and documentation. Runtime command behavior remains unchanged.

Changes

CLI naming alignment

Layer / File(s) Summary
CLI test helper renames
distributed_cli/tests/cli_client.rs, distributed_cli/tests/cli_skills_init.rs
Test helpers and their call sites now use distributed names.
Tooling and fixture name updates
scripts/graphql-skill-dry-run.sh, js/tests/sveltekit-vite.test.mjs
Local script variables and the embedded compiler fixture now use distributed names.
CLI documentation references
src/graphql/..., src/lib.rs, tests/e2e-ui/ui/...
Documentation and comments now reference the distributed CLI and commands.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 922f2

This PR standardizes stale CLI naming across comments, tests, fixtures, scripts, and documentation without changing the internal crate name or adding compatibility behavior. No actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: standardizing user-facing distributed CLI naming.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/distributed-cli-naming-cleanup

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Trivy (0.72.0)

Trivy execution failed: 2026-08-16T00:00:10Z FATAL Fatal error run error: fs scan error: scan error: scan failed: failed analysis: post analysis error: post analysis error: cloudformation scan error: fs filter error: fs filter error: walk error range error: stat .coderabbit-opengrep-fallback.54a5680e-1176-40a5-a42b-b56e51e531b6.yml: no such file or directory: range error: stat .coderabbit-opengrep-fallback.54a5680e-1176-40a5-a42b-b56e51e531b6.yml: no such file or directory


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patrickleet
patrickleet merged commit faf7617 into main Aug 16, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant