Skip to content

fix: preserve initiating CLI for lifecycle children - #244

Merged
patrickleet merged 4 commits into
v5from
fix/cli-child-executable-identity
Sep 12, 2026
Merged

patrickleet merged 4 commits into
v5from
fix/cli-child-executable-identity

Conversation

@patrickleet

@patrickleet patrickleet commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • carry the canonical absolute executable that initiated a discovered lifecycle through build, dev, UI, and framework child processes
  • make lifecycle-owned SvelteKit compilation use that identity even when a project command or an older distributed binary appears first on PATH
  • fail closed when lifecycle ownership is declared without a valid absolute executable identity
  • in lifecycle-owned mode invoke that initiating executable directly; standalone launcher prefixes are intentionally not forwarded into the trusted lifecycle command
  • keep standalone Vite command selection and the compatibility file-adapter path unchanged

Verification

  • cargo test -p distributed_cli lifecycle:: --lib -- --nocapture (27 passed)
  • npm run check
  • npm run build
  • node --test tests/sveltekit-vite.test.mjs (21 passed)
  • executor regression covers an initiating executable path containing spaces, a shadowing older PATH executable, and lifecycle-owned execution without a standalone launcher prefix

This stacks on the lifecycle-obligation fix in PR #243.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c90e88f8-1f2c-4266-a8cf-e1de707c776d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patrickleet
patrickleet changed the base branch from fix/live-root-index-handoff to v5 September 12, 2026 18:02
@patrickleet
patrickleet merged commit 11a0f56 into v5 Sep 12, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant