Uh oh!
There was an error while loading. Please reload this page.
fix(web): map queue/boot timeouts to SERVICE_UNAVAILABLE - #1111
Open
gildesmarais wants to merge 2 commits into
Open
fix(web): map queue/boot timeouts to SERVICE_UNAVAILABLE#1111gildesmarais wants to merge 2 commits into
gildesmarais wants to merge 2 commits into
Conversation
Users should not see site-blame GATEWAY_TIMEOUT copy when scrape-api timed out in our queue or Chromium boot. Reuse existing 503 decision; work/nil stay 504. Specs stub timeout_phase (released html2rss ~> 0.27 still lacks the reader; validated against that pin — path gem not required). Activate end-to-end after bumping html2rss past 81189aefe1cf827b7ff67f376df3bd9804aaa0d5.
This was referenced Aug 28, 2026
Dig timeout_phase from transport_meta and fall back to RequestTimedOut on the cause chain so Observability matches classifier phase mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ErrorClassifier: mapRequestTimedOutwithtimeout_phaseof queue/boot to existingSERVICE_UNAVAILABLE(503); work/nilstayGATEWAY_TIMEOUT(504).timeout_phase(released html2rss still lacks the reader; validated against current pin).Why
Users should not see site-blame GATEWAY_TIMEOUT copy when scrape-api timed out in our queue or Chromium boot.
Risk
81189aef.respond_to?(:timeout_phase)keeps pre-bump safe (no reader → nil → 504 as today).Review map
Review map: whole PR is small — start at
app/web/errors/error_classifier.rb.Validation
make readyexit 0Adjacent
Rollout: merge scrape-api → release/bump gem → merge web (web uses
respond_to?so pre-bump is safe).