Skip to content

Prevent #on_headers_complete callback from being called 2 times when parsing chunked requests#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HoneyryderChuck wants to merge 2 commits into
base:master
Choose a base branch
from
Open

Prevent #on_headers_complete callback from being called 2 times when parsing chunked requests #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d6cef0
Always call on_message_begin for start_req_or_res
atambo May 26, 2013
2fbc8cf
removing the headers complete callback from when finishing parsing a …
Oct 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/impl/http_parser/lolevel/HTTPParser.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -374,7 +374,6 @@ public int execute(ParserSettings settings, ByteBuffer data) {

if (H == ch) {
state = State.res_or_resp_H;
settings.call_on_message_begin(this);
} else {
type = ParserType.HTTP_REQUEST;
method = start_req_method_assign(ch);
Expand All@@ -384,6 +383,7 @@ public int execute(ParserSettings settings, ByteBuffer data) {
index = 1;
state = State.req_method;
}
settings.call_on_message_begin(this);
break;


Expand DownExpand Up@@ -1210,7 +1210,6 @@ public int execute(ParserSettings settings, ByteBuffer data) {
if (0 != (flags & F_TRAILING)) {
/* End of a chunked request */
state = new_message();
settings.call_on_headers_complete(this);
settings.call_on_message_complete(this);
break;
}
Expand Down