Skip to content

syntax error on ctx #10052

Description

@Clement-Lelievre

Describe the bug

Across several files, a bool statement is wrongly constructed IMO

One example:

CTX=init_empty_weightsifis_accelerate_availableelsenullcontext
=> instead of checking for truthiness of the function object is_accelerate_available itself, it should check for the truthiness of its return value I believe. So parentheses are needed, to call this function.

Proposed fix:

CTX=init_empty_weightsifis_accelerate_available() elsenullcontext

Reproduction

see

CTX=init_empty_weightsifis_accelerate_availableelsenullcontext

Logs

No response

System Info

not relevant

Who can help?

@yiyixuxu@say

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions