Skip to content

Add remote_decode to remote_utils - #10898

Merged
hlky merged 40 commits into
huggingface:mainfrom
hlky:remote-utils
Mar 2, 2025
Merged

Add remote_decode to remote_utils#10898
hlky merged 40 commits into
huggingface:mainfrom
hlky:remote-utils

Conversation

@hlky

@hlkyhlky commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

https://huggingface.co/blog/remote_vae

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@hlky
hlky requested a review from sayakpaulFebruary 25, 2025 06:44
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaulsayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Left some comments.

Comment threadsrc/diffusers/utils/remote_utils.py Outdated
Comment threadsrc/diffusers/utils/remote_utils.py Outdated
Comment threadsrc/diffusers/utils/remote_utils.py Outdated
@hlky

hlky commented Feb 25, 2025

Copy link
Copy Markdown
ContributorAuthor

Interface is unchanged for integrations of existing remote_decode method, main changes are docstrings and introducing return_type to support some other use cases.

@sayakpaul

Copy link
Copy Markdown
Member

@hlky WDYT about these changes https://github.com/sayakpaul/diffusers/pull/1/files?

@hlky

hlky commented Feb 25, 2025

Copy link
Copy Markdown
ContributorAuthor

@sayakpaul LGTM, feel free to push to the branch

@hlky

hlky commented Feb 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@bot /style

@github-actions

Copy link
Copy Markdown
Contributor

Style fixes have been applied. View the workflow run here.

@sayakpaulsayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed for merging but it would be good to have a test suite for the method for folks to understand how this should be used.

Comment threadsrc/diffusers/utils/remote_utils.py
Comment threadsrc/diffusers/utils/remote_utils.py
@hlky

hlky commented Feb 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Let's add the test suite before merge, best to make sure everything works. I'll need to temporarily create separate endpoints with the new containers, we'll let the tests run with those, merge, replace the existing containers, push the blog, and finally update the endpoint urls in our tests.

@hlky

hlky commented Mar 1, 2025

Copy link
Copy Markdown
ContributorAuthor

@bot /style

@github-actions

Copy link
Copy Markdown
Contributor

Style fixes have been applied. View the workflow run here.

@sayakpaulsayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments from my side. LMK if they make sense. Additionally, should these tests be nightly?

Comment threaddocs/source/en/hybrid_inference/overview.md
Comment threaddocs/source/en/hybrid_inference/overview.md
Comment threaddocs/source/en/hybrid_inference/overview.md
Comment threadsrc/diffusers/utils/remote_utils.py Outdated
Comment threadsrc/diffusers/utils/remote_utils.py
Comment threadsrc/diffusers/utils/remote_utils.py Outdated
Comment threadsrc/diffusers/utils/remote_utils.py Outdated
Comment threadtests/remote/test_remote_decode.py Outdated
hlkyand others added 2 commits March 1, 2025 17:03
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
@hlky

hlky commented Mar 1, 2025

Copy link
Copy Markdown
ContributorAuthor

@bot /style

@github-actions

Copy link
Copy Markdown
Contributor

Style fixes have been applied. View the workflow run here.


---

## Why use Hybrid Inference?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so here basically we listed the type of end points we offer, I think we can create a section for that later
for a "Why use ...?" section, let's highlight user benefits (I think currently the "key benefits" section is intended for)


## Key Benefits

- 🚀 **Reduced Requirements:** Access powerful models without expensive hardware.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not just reduced requirement though, the key is that we don't sacrificing quality/performance and also cost-efficient (currently free)

- 🎯 **Diverse Use Cases:** Fully compatible with Diffusers 🧨 and the wider community.
- 🔧 **Developer-Friendly:** Simple requests, fast responses.

---

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a section to showcase Real-World Use cases! we can link to comfy nodes etc

@hlky
hlky merged commit fc4229a into huggingface:mainMar 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hlky@HuggingFaceDocBuilderDev@sayakpaul@yiyixuxu