Skip to content

Add --lora_alpha and metadata handling to train_dreambooth_lora_sd3.py - #11783

Open
arnav-roy wants to merge 5 commits into
huggingface:mainfrom
arnav-roy:main
Open

Add --lora_alpha and metadata handling to train_dreambooth_lora_sd3.py#11783
arnav-roy wants to merge 5 commits into
huggingface:mainfrom
arnav-roy:main

Conversation

@arnav-roy

Copy link
Copy Markdown

What does this PR do?

Fixes#11730

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@arnav-roy

Copy link
Copy Markdown
Author

@linoytsaban Please review

@arnav-roy
arnav-roy marked this pull request as draft June 23, 2025 14:26
@arnav-roy
arnav-roy marked this pull request as ready for review June 23, 2025 14:27

@linoytsabanlinoytsaban left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @arnav-roy! I see lora_alpha is missing from the text_encoder config, other than that I think we're good :)

ifargs.train_text_encoder:
text_lora_config=LoraConfig(
r=args.rank,
lora_alpha=args.rank,
lora_dropout=args.lora_dropout,
init_lora_weights="gaussian",
target_modules=["q_proj", "k_proj", "v_proj", "out_proj"],

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions

Copy link
Copy Markdown
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actionsgithub-actionsBot added the stale Issues that haven't received updates label Jan 9, 2026
@yiyixuxu

Copy link
Copy Markdown
Collaborator

@arnav-roy can you make the request change?

@yiyixuxuyiyixuxu removed the stale Issues that haven't received updates label Jan 9, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

staleIssues that haven't received updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --lora_alpha and metadata handling in training scripts follow up

4 participants

@arnav-roy@HuggingFaceDocBuilderDev@yiyixuxu@linoytsaban