Skip to content

[GLM-Image] New Models Support - #12921

Closed
zRzRzRzRzRzRzR wants to merge 72 commits into
huggingface:mainfrom
zRzRzRzRzRzRzR:cogview
Closed

[GLM-Image] New Models Support#12921
zRzRzRzRzRzRzR wants to merge 72 commits into
huggingface:mainfrom
zRzRzRzRzRzRzR:cogview

Conversation

@zRzRzRzRzRzRzR

@zRzRzRzRzRzRzRzRzRzRzRzRzRzR commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

@yiyixuxu@sayakpaul For check with model

@zRzRzRzRzRzRzR
zRzRzRzRzRzRzR marked this pull request as draft January 7, 2026 11:01
yiyixuxu
yiyixuxu reviewed Jan 7, 2026
View reviewed changes
Comment threadsrc/diffusers/pipelines/glm_image/pipeline_glm_image.py Outdated
yiyixuxu
yiyixuxu reviewed Jan 8, 2026
View reviewed changes
Comment threadsrc/diffusers/models/transformers/transformer_glm_image.py Outdated
@zRzRzRzRzRzRzR
zRzRzRzRzRzRzR marked this pull request as ready for review January 8, 2026 07:56
@zRzRzRzRzRzRzRzRzRzRzRzRzRzR changed the title GLM-Imge for test[GLM-Imge] New Models SupportJan 8, 2026
@zRzRzRzRzRzRzRzRzRzRzRzRzRzR changed the title [GLM-Imge] New Models Support[GLM-Image] New Models SupportJan 8, 2026
@zRzRzRzRzRzRzRzRzRzRzRzRzRzR mentioned this pull request Jan 8, 2026
Merged
sayakpaul
sayakpaul reviewed Jan 8, 2026
View reviewed changes

@sayakpaulsayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking quite good!

I think all the precomputations are in place and the use of caching also reads quite simple.

Comment threaddocs/source/en/api/pipelines/glm_image.md Outdated
Comment threaddocs/source/en/api/pipelines/glm_image.md
Comment threadsrc/diffusers/models/embeddings.py Outdated
Comment threadsrc/diffusers/models/transformers/transformer_glm_image.py Outdated
Comment threadsrc/diffusers/models/transformers/transformer_glm_image.py Outdated
Comment threadsrc/diffusers/pipelines/glm_image/pipeline_glm_image.py Outdated
Comment threadsrc/diffusers/pipelines/glm_image/pipeline_glm_image.py
Comment threadsrc/diffusers/pipelines/glm_image/pipeline_glm_image.py Outdated
Comment threadsrc/diffusers/pipelines/glm_image/pipeline_glm_image.py Outdated
Comment threadsrc/diffusers/pipelines/glm_image/pipeline_glm_image.py
@github-actions

github-actionsBot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

Style fix is beginning .... View the workflow run here.

yiyixuxu
yiyixuxu reviewed Jan 13, 2026
View reviewed changes
Comment threadsrc/diffusers/pipelines/glm_image/pipeline_glm_image.py Outdated
@david6666666david6666666 mentioned this pull request Jan 13, 2026
Closed
38 tasks
@sayakpaulsayakpaul mentioned this pull request Jan 13, 2026
Merged
@zRzRzRzRzRzRzR

zRzRzRzRzRzRzR commented Jan 13, 2026

Copy link
Copy Markdown
ContributorAuthor

Using as #12973 , merged

@zRzRzRzRzRzRzR
zRzRzRzRzRzRzR deleted the cogview branch July 7, 2026 07:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxuyiyixuxuyiyixuxu approved these changes
@sayakpaulsayakpaulsayakpaul left review comments
@zucchini-nlpzucchini-nlpzucchini-nlp left review comments
+1 more reviewer
@yhyang201yhyang201yhyang201 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zRzRzRzRzRzRzR@sayakpaul@yiyixuxu@yhyang201@zucchini-nlp