Uh oh!
There was an error while loading. Please reload this page.
Fix group-offloading bug - #13211
Merged
Merged
Conversation
Add fallback synchronous onload for conditionally-executed modules.
sayakpaul
commented
Mar 4, 2026
Member
Could we also add a test for this code path in https://github.com/huggingface/diffusers/blob/main/tests/hooks/test_group_offloading.py? |
SHYuanBest
commented
Mar 4, 2026
ContributorAuthor
done. |
sayakpaul
approved these changes
Mar 4, 2026
sayakpaul
left a comment
Member
There was a problem hiding this comment.
Thanks! A few small comments. I also ran the tests on my end and they are passing.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
terarachang pushed a commit
to terarachang/diffusers
that referenced
this pull request
Apr 30, 2026
* Implement synchronous onload for offloaded parameters Add fallback synchronous onload for conditionally-executed modules. * add test for new code path about group-offloading * Update tests/hooks/test_group_offloading.py Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> * use unittest.skipIf and update the comment --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #13208 and #13210
cc @yiyixuxu
cc @sayakpaul
cc @dg845