Skip to content

skip invalid test case for helios pipeline - #13218

Merged
yiyixuxu merged 4 commits into
huggingface:mainfrom
kaixuanliu:helio-fix
Mar 18, 2026
Merged

skip invalid test case for helios pipeline#13218
yiyixuxu merged 4 commits into
huggingface:mainfrom
kaixuanliu:helio-fix

Conversation

@kaixuanliu

@kaixuanliukaixuanliu commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

In helios pipeline, the latents are always in FP32 format: L798, hence we should skip the test_save_load_float16 test case, rather than adjust the tolerance.

@kaixuanliu
skip invalid test case for helio pipeline
8202a14
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
@kaixuanliu

kaixuanliu commented Mar 6, 2026

Copy link
Copy Markdown
ContributorAuthor

@DN6 pls help review, thx!

@kaixuanliu

kaixuanliu commented Mar 16, 2026

Copy link
Copy Markdown
ContributorAuthor

@yiyixuxu Hi, can you help review? Thx!

@yiyixuxu

yiyixuxu commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

hey @kaixuanliu
latents are initially created in float32 and processed in the actual dtype of transformere though https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/helios/pipeline_helios.py#L817

did I miss anything?

@kaixuanliu
Merge branch 'main' into helio-fix
6a67d72
@kaixuanliu
update skip reason
7e138fc
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
@kaixuanliu

kaixuanliu commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

@yiyixuxu Thx for the comment! Yes, I am afraid you are right. But for this pipeline, it has a lot of modules using mixed precision, such as: keep_in_fp32_module, FP32LayerNorm, L435-L437 and HeliosOutputNorm, hence I suggest to skip this test case like in WanVACE pipeline, and I have updated the skip reason. Do you think it is OK?

yiyixuxu
yiyixuxu approved these changes Mar 18, 2026
View reviewed changes

@yiyixuxuyiyixuxu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu
yiyixuxu merged commit 8e4b560 into huggingface:mainMar 18, 2026
7 checks passed
@hlkyhlky mentioned this pull request Apr 29, 2026
Open
terarachang pushed a commit to terarachang/diffusers that referenced this pull request Apr 30, 2026
@kaixuanliu
skip invalid test case for helios pipeline (huggingface#13218)
6fb3fa7
* skip invalid test case for helio pipeline
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
* update skip reason
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
---------
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxuyiyixuxuyiyixuxu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaixuanliu@yiyixuxu