Skip to content

[tests] fix test_from_save_pretrained_dtype_inference - #13872

Merged
sayakpaul merged 23 commits into
mainfrom
fix-dtype-tests-models
Jul 3, 2026
Merged

[tests] fix test_from_save_pretrained_dtype_inference#13872
sayakpaul merged 23 commits into
mainfrom
fix-dtype-tests-models

Conversation

@sayakpaul

@sayakpaulsayakpaul commented Jun 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Context: #13862 (comment)

I have run the tests we were skipping before and they're passing now.

@github-actionsgithub-actionsBot added size/M PR with diff < 200 LOC tests and removed size/M PR with diff < 200 LOC labels Jun 5, 2026
@github-actionsgithub-actionsBot added the size/M PR with diff < 200 LOC label Jun 5, 2026
@sayakpaul
sayakpaul requested review from DN6 and yiyixuxuJune 5, 2026 10:59
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Jun 5, 2026

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

yiyixuxu
yiyixuxu reviewed Jun 8, 2026
View reviewed changes
Comment threadsrc/diffusers/models/modeling_utils.py Outdated
@sayakpaul
sayakpaul requested a review from yiyixuxuJune 9, 2026 04:28
@sayakpaul

sayakpaul commented Jun 9, 2026

Copy link
Copy Markdown
MemberAuthor

Some test failures in https://github.com/huggingface/diffusers/actions/runs/27183408863/job/80247268518?pr=13872 are unrelated. Fixing the test_from_save_pretrained_dtype_inference related ones.

@sayakpaul

sayakpaul commented Jun 9, 2026

Copy link
Copy Markdown
MemberAuthor

Failing tests are now unrelated and I have opened a PR to fix those:
#13894

DN6
DN6 reviewed Jun 9, 2026
View reviewed changes

@DN6DN6 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comment.

Comment threadsrc/diffusers/models/modeling_utils.py Outdated
break

if dtype_present_in_args and fp32_modules is not None:
logger.debug(

@DN6DN6Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would make this logger.warning

@sayakpaul
sayakpaul requested a review from DN6June 9, 2026 12:20
DN6
DN6 approved these changes Jul 2, 2026
View reviewed changes

@DN6DN6 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to merge once conflicts are resolved

DN6
DN6 reviewed Jul 2, 2026
View reviewed changes
Comment threadsrc/diffusers/models/modeling_utils.py Outdated
@sayakpaul
sayakpaul merged commit 72eb60c into mainJul 3, 2026
36 of 37 checks passed
@sayakpaul

sayakpaul commented Jul 3, 2026

Copy link
Copy Markdown
MemberAuthor

Failing tests are unrelated.

@sayakpaul
sayakpaul deleted the fix-dtype-tests-models branch July 3, 2026 03:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DN6DN6DN6 approved these changes
@yiyixuxuyiyixuxuAwaiting requested review from yiyixuxu

Assignees

No one assigned

Labels

modelssize/MPR with diff < 200 LOCtests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sayakpaul@HuggingFaceDocBuilderDev@DN6@yiyixuxu