Skip to content

Log WanAnimate interpolation resizing as a warning - #13936

Closed
wunianze666-netizen wants to merge 1 commit into
huggingface:mainfrom
wunianze666-netizen:fix/wan-interpolation-warning-logger
Closed

Log WanAnimate interpolation resizing as a warning#13936
wunianze666-netizen wants to merge 1 commit into
huggingface:mainfrom
wunianze666-netizen:fix/wan-interpolation-warning-logger

Conversation

@wunianze666-netizen

@wunianze666-netizenwunianze666-netizen commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the direct interpolation print(...) in WanAnimatePipeline.prepare_prev_segment_cond_latents() with logger.warning(...)
  • add a regression test that captures the warning when previous-segment conditioning frames are resized

Why

This path runs inside library code, so writing directly to stdout makes the message harder to control in downstream applications. The rest of the pipeline already uses structured warnings for similar resizing notices.

Validation

  • python -m pytest tests/pipelines/wan/test_wan_animate.py -k test_prepare_prev_segment_cond_latents_logs_interpolation_warning -q
  • ruff check src/diffusers/pipelines/wan/pipeline_wan_animate.py tests/pipelines/wan/test_wan_animate.py
  • ruff format --check src/diffusers/pipelines/wan/pipeline_wan_animate.py tests/pipelines/wan/test_wan_animate.py
  • python -m py_compile src/diffusers/pipelines/wan/pipeline_wan_animate.py tests/pipelines/wan/test_wan_animate.py

Issue Linkage

This is a small logging cleanup and is not tied to an existing tracked issue.

@github-actionsgithub-actionsBot added size/M PR with diff < 200 LOC tests pipelines labels Jun 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @wunianze666-netizen, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Fixes #1234) to the PR description so the issue is linked. See the contribution guide for more details. If this PR intentionally does not fix a tracked issue, a maintainer can add the no-issue-needed label to silence this reminder.

@wunianze666-netizen
wunianze666-netizenforce-pushed the fix/wan-interpolation-warning-logger branch from 99433bb to ed13fd9CompareAugust 13, 2026 06:06
@github-actionsgithub-actionsBot added size/S PR with diff < 50 LOC and removed size/M PR with diff < 200 LOC labels Aug 13, 2026
@wunianze666-netizen

Copy link
Copy Markdown
ContributorAuthor

Closing this one-off PR in favor of the pattern-level coordination in #14479. I will wait for maintainer confirmation there, consolidate the approved scope, run the current self-review workflow, and include exact test results before opening a replacement.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipelinessize/SPR with diff < 50 LOCtests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@wunianze666-netizen