Uh oh!
There was an error while loading. Please reload this page.
[tests] component manager tests - #13961
Merged
Merged
Conversation
sayakpaul
marked this pull request as ready for review
June 16, 2026 06:18
Contributor
Hi @sayakpaul, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
Uh oh!
There was an error while loading. Please reload this page.
yiyixuxu added a commit
that referenced
this pull request
Jul 31, 2026
Back to the version introduced in #13961, adapted only for this PR's renames (memory_reserve_margin -> memory_reserve, _patch_free_memory -> _patch_memory_stats). Also comment the Z-Image card specs with why each card behaves the way it does. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds tests for the component manager in modular pipelines.
ComponentsManagerTesterMixin.ModularPipelineOffloadTesterMixin. I have only used it in the Flux pipeline tests to keep things minimal.Notes:
We're mocking the available memory and free memory in the tests and checking against those simulations. So, in many cases we don't actually need a real GPU or a GPU with a certain amount of memory.
In the next PR, I want to introduce the
maximum_total_models_sizeflag (and related tests).