[tests] Pipeline test refactor - #14113
Merged
Merged
Conversation
Member
Author
|
/diffusers-bot pytest tests/pipelines/flux/test_pipeline_flux.py::TestFluxPipeline::test_float16_inference |
Contributor
|
❌ |
sayakpaul
commented
Jul 3, 2026
| @@ -1,9 +1,15 @@ | |||
| import contextlib | |||
Member
Author
There was a problem hiding this comment.
Changes here are migrating to pytest.
sayakpaul
commented
Jul 3, 2026
|
|
||
|
|
||
| @is_staging_test | ||
| class PipelinePushToHubTester(unittest.TestCase): |
Member
Author
There was a problem hiding this comment.
Moved to tests/pipelines/test_pipeline_utils.py
sayakpaul
marked this pull request as ready for review
July 6, 2026 03:07
Member
Author
|
All the failing tests are quite unrelated |
DN6
reviewed
Jul 6, 2026
| @require_torch_accelerator | ||
| @slow | ||
| class Base4bitTests(unittest.TestCase): | ||
| class Base4bitTests: |
Collaborator
There was a problem hiding this comment.
For pipeline quantization tests, why not use the Mixin approach that we have with models? Or is that planned for a follow up?
This was referenced Jul 19, 2026
This was referenced Jul 23, 2026
6 tasks
This was referenced Aug 20, 2026
Merged
Merged
sayakpaul
added a commit
that referenced
this pull request
Sep 1, 2026
* refactor c* pipeline tests. Migrate the remaining `tests/pipelines/` directories starting with C to the config class + composable pytest mixins introduced in #14113: chroma, chronoedit, cogview3, consisid, consistency_models, controlnet, controlnet_flux, controlnet_hunyuandit, controlnet_sd3 and cosmos. cogvideo and cogview4 were already migrated. Notable points beyond the mechanical conversion: - Expected slices switch from the `"np"` layout (`[0, -3:, -3:, -1]`) to the `"pt"` one (`[0, -1, -3:, -3:]`); the values themselves are unchanged. - The Cosmos `safety_checker` overrides (save/load, variants, dtype dict, encode_prompt) were duplicated across five files and now live in a shared `CosmosSafetyCheckerTesterMixin` in `tests/pipelines/cosmos/testing_utils.py`. - chroma and controlnet_flux import `FluxIPAdapterTesterMixin` from `..flux.testing_utils` rather than the old `..test_pipelines_common` one. - `PipelineTesterMixin.test_save_load_float16` now passes the non-deprecated `dtype=` to `from_pretrained` instead of `torch_dtype=`, which the Cosmos2.5 `from_pretrained` wrappers read when casting the safety checker they inject. - Dropped along the way, matching #14619: `PipelineLatentTesterMixin`, `PipelineKarrasSchedulerTesterMixin`, the attention-slicing and xformers tests, and the `test_ip_adapter` overrides that only supplied an `expected_pipe_slice`. `pytest tests/pipelines/{chroma,chronoedit,cogview3,consisid,consistency_models,controlnet,controlnet_flux,controlnet_hunyuandit,controlnet_sd3,cosmos}` gives 14 failed, 1014 passed, 82 skipped. All 14 failures are in cosmos and reproduce unchanged on main: `DummyCosmosSafetyChecker` is a parameter-less `ModelMixin` with a single non-persistent buffer, so accelerate does not hook it for sequential offload and a reloaded pipeline gets a fresh fp32 one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
generate_pipeline_level_tests.pyscript. Will be done in subsequent PRs once other mixins, such as LoRA, are added.pytestfeatures as much as possible. This is particularly reflected in the use of custom fixtures. For example,base_pipe_output. This way, we don't have to compute it for every test that requires it.I have only refactored the Flux pipeline tests to use the new mixin, as we do in other PRs. Will open subsequent PRs for other pipelines and involve the community.