Skip to content

fix: fix: correct grammar "same type to" β†’ "same type as" in error messages - #14511

Closed
Ricardo-M-L wants to merge 1 commit into
huggingface:mainfrom
Ricardo-M-L:fix/grammar-same-type-as-in-error-messages-clean
Closed

fix: fix: correct grammar "same type to" β†’ "same type as" in error messages#14511
Ricardo-M-L wants to merge 1 commit into
huggingface:mainfrom
Ricardo-M-L:fix/grammar-same-type-as-in-error-messages-clean

Conversation

@Ricardo-M-L

@Ricardo-M-LRicardo-M-L commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Corrects the grammar error "must be the same type to" -> "must be the same type as" in user-facing error messages across 30 files (pure message-text change, no logic).

No linked issue: pure text cleanup with no user-facing bug report. Happy to add no-issue-needed context if maintainers prefer.

Rebase of #13388.

160 occurrences across 158 pipeline files used the incorrect phrase
"should be the same type to" instead of "should be the same type as".
2 files already had the correct form.
@github-actions

Copy link
Copy Markdown
Contributor

Hi @Ricardo-M-L, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Fixes #1234) to the PR description so the issue is linked. See the contribution guide for more details. If this PR intentionally does not fix a tracked issue, a maintainer can add the no-issue-needed label to silence this reminder.

@github-actions

github-actionsBot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Hi @Ricardo-M-L, a follow-up on the reminder above: this PR still does not link an issue it fixes.

Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice. Adding a closing keyword (e.g. Fixes #1234) to the PR description, or a maintainer adding the no-issue-needed label, will prevent that.

@yiyixuxu

Copy link
Copy Markdown
Collaborator

hi @Ricardo-M-L

I'm closing this per the AI-assisted contribution guidelines: https://huggingface.co/docs/diffusers/main/en/conceptual/contribution#ai-assisted-and-agentic-contributions

We're seeing an increasing volume of contributions and review capacity is currently our bottleneck, so the guidelines ask for maintainer acknowledgment on an issue before a PR is opened β€” that's what lets us prioritize the bugs users are actually hitting.

Normally we'd leave this as a suggestion and keep working with a contributor on the PR, but the volume here has made that impractical β€” these have come in faster than we can review them, so I'm closing all of them that you've opened rather than reviewing them individually.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Ricardo-M-L@yiyixuxu