Uh oh!
There was an error while loading. Please reload this page.
Implement CustomDiffusionAttnProcessor2_0. - #4604
Conversation
HuggingFaceDocBuilderDev
commented
Aug 15, 2023
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
sayakpaul
commented
Aug 15, 2023
@eliphatfs let me know if this PR is ready for review. |
Hi, how do I do the |
…`. (#1) * Update attnprocessor.md * Update attention_processor.py
eliphatfs
commented
Aug 16, 2023
I don't find existing tests for CustomDiffusionAttnProcessor, so I will skip adding that for |
Uh oh!
There was an error while loading. Please reload this page.
sayakpaul
left a comment
There was a problem hiding this comment.
Looking good, thank you!
- Could we add this conditional initialization of this class in the training script? Here's an example: https://github.com/huggingface/diffusers/blob/main/examples/dreambooth/train_dreambooth_lora.py#L876C1-L880C1.
@yiyixuxu could you also give this a look?
eliphatfs
commented
Aug 16, 2023
The CI complains about my code style. How do I spot the problem? |
You can run Guidance: https://github.com/huggingface/diffusers/blob/main/CONTRIBUTING.md |
eliphatfs
commented
Aug 16, 2023
Sorry I didn't read the guide carefully; I have updated the code formatting, but there are extra errors when I wrong |
sayakpaul
commented
Aug 16, 2023
Cc @DN6 could you help here? |
DN6
commented
Aug 16, 2023
@eliphatfs What version of |
eliphatfs
commented
Aug 17, 2023
Oh it was |
Done! |
eliphatfs
commented
Aug 17, 2023
Forgot to update loaders. Now |
sayakpaul
commented
Aug 17, 2023
@DN6 could you give this a look? |
eliphatfs
commented
Aug 24, 2023
Bump? |
sayakpaul
commented
Aug 25, 2023
eliphatfs
commented
Sep 13, 2023
I see the PRs you mentioned have been merged. Shall we continue working on this thing? |
sayakpaul
left a comment
There was a problem hiding this comment.
Nice this works for me. Thank you so much for implementing this!
sayakpaul
commented
Sep 15, 2023
Ah, we have some failures on the CI and merge conflicts. Let's make sure to resolve them. |
eliphatfs
commented
Sep 16, 2023
I have resolved the conflict; looking into the CI failures. |
eliphatfs
commented
Sep 16, 2023
Sorry but I request a re-run of the tests. It seemed to me that the errors are not relevant to this PR. CI is complaining about a field missing in a huggingface API result. I guess it may be due to API changes and since I have merged the changes in diffusers |
patrickvonplaten
left a comment
There was a problem hiding this comment.
Ok for me. @sayakpaul@DN6@yiyixuxu wdyt?
sayakpaul
left a comment
There was a problem hiding this comment.
Okay for me to merge once the CI is green (except the documentation workflow).
* Implement `CustomDiffusionAttnProcessor2_0` * Doc-strings and type annotations for `CustomDiffusionAttnProcessor2_0`. (huggingface#1) * Update attnprocessor.md * Update attention_processor.py * Interops for `CustomDiffusionAttnProcessor2_0`. * Formatted `attention_processor.py`. * Formatted doc-string in `attention_processor.py` * Conditional CustomDiffusion2_0 for training example. * Remove unnecessary reference impl in comments. * Fix `save_attn_procs`.
* Implement `CustomDiffusionAttnProcessor2_0` * Doc-strings and type annotations for `CustomDiffusionAttnProcessor2_0`. (huggingface#1) * Update attnprocessor.md * Update attention_processor.py * Interops for `CustomDiffusionAttnProcessor2_0`. * Formatted `attention_processor.py`. * Formatted doc-string in `attention_processor.py` * Conditional CustomDiffusion2_0 for training example. * Remove unnecessary reference impl in comments. * Fix `save_attn_procs`.
What does this PR do?
Fixes#4588
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul@nupurkmr9