Skip to content

LCM-LoRA docs - #5782

Merged
patil-suraj merged 15 commits into
mainfrom
lcm-lora-docs
Nov 16, 2023
Merged

LCM-LoRA docs#5782
patil-suraj merged 15 commits into
mainfrom
lcm-lora-docs

Conversation

@patil-suraj

@patil-surajpatil-suraj commented Nov 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds docs for performing inference with LCM-LoRAs for most common pipelines/tasks. It removed the previous doc page and added two new docs in tutorials section. Let me know if this is the right section to put such docs @stevhliu@sayakpaul@patrickvonplaten

  • For LCM-LoRA
  • For fully distilled LCMs

patrickvonplaten
patrickvonplaten reviewed Nov 13, 2023
View reviewed changes

@patrickvonplatenpatrickvonplaten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool doc - just note that we already have some lcm-lora docs here:
https://github.com/huggingface/diffusers/blob/main/docs/source/en/using-diffusers/lcm.md

Shall we split all the docs on two sides (so remove what's already in LCM?)
and this doc page is currently not displayed because lcm_lora.md is not aded to _toctree: https://github.com/huggingface/diffusers/blob/main/docs/source/en/_toctree.yml

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Nov 14, 2023•
edited
Loading

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@stevhliustevhliu mentioned this pull request Nov 15, 2023
Merged
@patil-surajpatil-suraj changed the title [WIP] LCM-LoRA docsLCM-LoRA docsNov 15, 2023
patrickvonplaten
patrickvonplaten approved these changes Nov 15, 2023
View reviewed changes

@patrickvonplatenpatrickvonplaten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@patrickvonplaten

patrickvonplaten commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Could you transfer your code examples also directly to the model cards here: https://huggingface.co/latent-consistency

stevhliu
stevhliu approved these changes Nov 15, 2023
View reviewed changes

@stevhliustevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool! 🔥

Comment threaddocs/source/en/_toctree.yml Outdated
Comment threaddocs/source/en/_toctree.yml Outdated
Comment threaddocs/source/en/_toctree.yml Outdated
Comment threaddocs/source/en/tutorials/inference_with_lcm_lora.md Outdated
Comment threaddocs/source/en/tutorials/inference_with_lcm_lora.md Outdated
Comment threaddocs/source/en/tutorials/inference_with_lcm.md Outdated
Comment threaddocs/source/en/tutorials/inference_with_lcm.md Outdated
Comment threaddocs/source/en/tutorials/inference_with_lcm.md Outdated
Comment threaddocs/source/en/tutorials/inference_with_lcm.md Outdated
Comment threaddocs/source/en/tutorials/inference_with_lcm.md Outdated
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes
Comment threaddocs/source/en/tutorials/inference_with_lcm.md
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes
Comment threaddocs/source/en/tutorials/inference_with_lcm.md
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes
Comment threaddocs/source/en/tutorials/inference_with_lcm.md Outdated
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes
Comment threaddocs/source/en/tutorials/inference_with_lcm.md
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes
Comment threaddocs/source/en/tutorials/inference_with_lcm.md Outdated
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes
Comment threaddocs/source/en/tutorials/inference_with_lcm_lora.md Outdated
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes
Comment threaddocs/source/en/tutorials/inference_with_lcm_lora.md
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes
Comment threaddocs/source/en/tutorials/inference_with_lcm_lora.md Outdated
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes
Comment threaddocs/source/en/tutorials/inference_with_lcm_lora.md
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes
Comment threaddocs/source/en/tutorials/inference_with_lcm_lora.md Outdated
sayakpaul
sayakpaul reviewed Nov 16, 2023
View reviewed changes

@sayakpaulsayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool and highly detailed!

@patil-suraj

patil-suraj commented Nov 16, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I've have addressed all the comments. Merging now

@patil-suraj
patil-suraj merged commit a042909 into mainNov 16, 2023
@patil-suraj
patil-suraj deleted the lcm-lora-docs branch November 16, 2023 15:19
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@patil-suraj@stevhliuJimmy
LCM-LoRA docs (huggingface#5782)
f92fcf2
* begin doc
* fix examples
* add in toctree
* fix toctree
* improve copy
* improve introductions
* add lcm doc
* fix filename
* Apply suggestions from code review
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
* address Sayak's comments
* remove controlnet aux
* open in colab
* move to Specific pipeline examples
* update controlent and adapter examples
---------
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sayakpaulsayakpaulsayakpaul left review comments
@stevhliustevhliustevhliu approved these changes
+1 more reviewer
@patrickvonplatenpatrickvonplatenpatrickvonplaten approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@patil-suraj@HuggingFaceDocBuilderDev@patrickvonplaten@sayakpaul@stevhliu