Uh oh!
There was an error while loading. Please reload this page.
Fix bugs of Stable Diffusion - #6202
Conversation
sayakpaul
commented
Dec 18, 2023
Cc: @williamberman here. |
| lora_scale=lora_scale, | ||
| clip_skip=self.clip_skip, | ||
| ) | ||
| if prompt_embeds is None and negative_prompt_embeds is None: |
There was a problem hiding this comment.
this is not correct. Even if prompt_embeds is not None self.encode_prompt should be called (see how the prompt_embeds variable is passed to the function)
There was a problem hiding this comment.
Then please see https://github.com/huggingface/diffusers/blob/main/examples/dreambooth/train_dreambooth_lora.py#L1239,
when prompt_embeds is given, the model does not give prompt to the pipeline.
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
What does this PR do?
Fix bugs of Stable Diffusion mentioned in #6201 , might could merge together with #6135
Fixes#6201
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@patrickvonplaten and @sayakpaul
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.