Uh oh!
There was an error while loading. Please reload this page.
[ip-adapter] fix problem using embeds with the plus version of ip adapters - #7189
Conversation
Uh oh!
There was an error while loading. Please reload this page.
HuggingFaceDocBuilderDev
commented
Mar 3, 2024
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
asomoza
commented
Mar 3, 2024
Tested all the combinations I could think of with SDXL, the image isn't that nice but is faster to just use all three ip adapters at the same time ^^ Do the SD 1.5 versions have different dimensions? there's six of them. |
sayakpaul
commented
Mar 3, 2024
Could do a quick check on the checkpoints maybe? |
asomoza
commented
Mar 3, 2024
I did and it worked with almost all of them except this one:
This also reminded me that there's one with the big image encoder for the SDXL ones, so I tested it and it didn't work either:
but those errors are not related to this PR |
sayakpaul
commented
Mar 3, 2024
I see. I think that needs fixing then. Would you mind opening an issue for this and we can work on that in a separate PR? |
asomoza
commented
Mar 3, 2024
It was an obvious mistake on my part, since both of those use a different image encoder and I was using them in combination with the normal ones, that was the error, I can't mix the adapters that use different image encoders since we load one for all of them. They work as expected if I use them alone. |
What does this PR do?
Allows the use of 4D tensors to be able to pass embeds made with the IP Adapter PLUS versions
Fixes#7168
How to test:
Who can review?
@yiyixuxu@sayakpaul
Also cc: @fabiorigano because of #7186