Skip to content

[docs] IP-Adapter image embedding - #7226

Merged
stevhliu merged 5 commits into
huggingface:mainfrom
stevhliu:ip-adapters
Mar 8, 2024
Merged

[docs] IP-Adapter image embedding#7226
stevhliu merged 5 commits into
huggingface:mainfrom
stevhliu:ip-adapters

Conversation

@stevhliu

@stevhliustevhliu commented Mar 5, 2024

Copy link
Copy Markdown
Member

Continuation of #7016 with some light edits to the ip_adapter_image_embeds and masking sections, and adds IPAdapterMaskProcessor.preprocess to the API docs.

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Mar 5, 2024

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

yiyixuxu
yiyixuxu approved these changes Mar 5, 2024
View reviewed changes

@yiyixuxuyiyixuxu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

sayakpaul
sayakpaul reviewed Mar 5, 2024
View reviewed changes
Comment threaddocs/source/en/using-diffusers/ip_adapter.md Outdated
sayakpaul
sayakpaul reviewed Mar 5, 2024
View reviewed changes
Comment threaddocs/source/en/using-diffusers/ip_adapter.md Outdated
sayakpaul
sayakpaul reviewed Mar 5, 2024
View reviewed changes
Comment threaddocs/source/en/using-diffusers/ip_adapter.md Outdated
sayakpaul
sayakpaul reviewed Mar 5, 2024
View reviewed changes
Comment threaddocs/source/en/api/loaders/ip_adapter.md
sayakpaul
sayakpaul reviewed Mar 5, 2024
View reviewed changes
Comment threaddocs/source/en/using-diffusers/ip_adapter.md Outdated
sayakpaul
sayakpaul reviewed Mar 5, 2024
View reviewed changes
Comment threaddocs/source/en/using-diffusers/ip_adapter.md Outdated
</div>
</div>

When there is more than one input IP-Adapter image, load them as a list to ensure each image is assigned to a different IP-Adapter.

@sayakpaulsayakpaulMar 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiyixuxu just to confirm can we assign multiple images to a single IP Adapter? If so, I think this line needs to rephrased.

sayakpaul
sayakpaul reviewed Mar 5, 2024
View reviewed changes
Comment threaddocs/source/en/using-diffusers/ip_adapter.md Outdated
sayakpaul
sayakpaul reviewed Mar 5, 2024
View reviewed changes
Comment threaddocs/source/en/using-diffusers/ip_adapter.md
sayakpaul
sayakpaul reviewed Mar 5, 2024
View reviewed changes

@sayakpaulsayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Left a couple of comments.

@stevhliustevhliu mentioned this pull request Mar 6, 2024
Closed
@stevhliu
stevhliu requested a review from sayakpaulMarch 7, 2024 22:13
sayakpaul
sayakpaul approved these changes Mar 8, 2024
View reviewed changes

@sayakpaulsayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, Steven!

@stevhliu
stevhliu merged commit 1f22c98 into huggingface:mainMar 8, 2024
@stevhliu
stevhliu deleted the ip-adapters branch March 8, 2024 16:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxuyiyixuxuyiyixuxu approved these changes
@sayakpaulsayakpaulsayakpaul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stevhliu@HuggingFaceDocBuilderDev@yiyixuxu@sayakpaul