Uh oh!
There was an error while loading. Please reload this page.
[Model Card] standardize advanced diffusion training sdxl lora - #7615
Conversation
linoytsaban
left a comment
There was a problem hiding this comment.
Hey @chiral-carbon! same small comment from the sd15 PR, applies here too - since it can be either a LoRA or a DoRA, we need to check if the use_dora arg is True and adapt the tag accordingly :)
other than that, all good!
chiral-carbon
commented
Apr 17, 2024
thanks @linoytsaban! have addressed the |
HuggingFaceDocBuilderDev
commented
Apr 18, 2024
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| "stable-diffusion-xl-diffusers", | ||
| "text-to-image", | ||
| "diffusers", | ||
| "lora", |
There was a problem hiding this comment.
last thing 😊- we need to switch "lora" -> lora in the tags here (to use the var defined in line 114)
linoytsaban
commented
May 28, 2024
Hey @chiral-carbon! I think once we address the "lora" -> lora change it'll also pass all the tests and we can merge :) |
chiral-carbon
commented
Jun 6, 2024
Hi @linoytsaban my apologies, I completely missed this message, will do it asap! |
chiral-carbon
commented
Jun 10, 2024
@linoytsaban pushed it! |
linoytsaban
commented
Jun 11, 2024
Thanks @chiral-carbon! I'm not sure what's failing the quality tests now 🧐 could you run make fix up please? |
chiral-carbon
commented
Jun 11, 2024
hi @linoytsaban this is the output of it seems that it has no module named models.auto? |
tolgacangoz
commented
Jun 11, 2024
Could you run |
chiral-carbon
commented
Jun 12, 2024
this is the output of have pushed it as well, it changed the formatting of the |
chiral-carbon
commented
Jun 12, 2024
should I also run |
chiral-carbon
commented
Jul 11, 2024
hi @linoytsaban@tolgacangoz! is this PR good to be merged? |
It seems that there are conflicts that must be resolved. Could you resolve them? |
chiral-carbon
commented
Jul 15, 2024
@tolgacangoz done |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
chiral-carbon
commented
Oct 31, 2024
@a-r-r-o-w hi! Is this and the PR #7613 good to be merged? |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
sayakpaul
commented
Nov 25, 2024
@linoytsaban a gentle ping here |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
chiral-carbon
commented
Apr 3, 2025
@sayakpaul@a-r-r-o-w@linoytsaban should I close this PR unless it is good to be merged? has been stale for a while |
a-r-r-o-w
commented
Apr 3, 2025
Sorry for the delay. I'm triggering the tests again to make sure they pass and will merge once they do |
What does this PR do?
Fixes#6891 for Advanced Diffusion Training SDXL with LoRA
Notebook example: Jupyter notebook
Example model card: Model Card
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul@linoytsaban