Uh oh!
There was an error while loading. Please reload this page.
fix multicontrolnet save_pretrained logic for compatibility - #7821
Merged
Conversation
ContributorAuthor
@sayakpaul The PR corresponding to the content of issue report (#7814 ). |
rebel-kblee
commented
May 10, 2024
ContributorAuthor
Can you please check this PR? @yiyixuxu |
rebel-kblee
commented
May 13, 2024
ContributorAuthor
Hi @sayakpaul, can you assign another reviewer for this PR? |
sayakpaul
commented
May 13, 2024
Member
Please give it a few more days. It will be reviewed by @yiyixuxu. |
HuggingFaceDocBuilderDev
commented
May 13, 2024
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
commented
May 13, 2024
Collaborator
thanks for the PR! |
sayakpaul added a commit
that referenced
this pull request
Dec 23, 2024
fix multicontrolnet save_pretrained logic for compatibility Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix an inconsistency between
from_pretrainedandsave_pretrainedwithin the Multicontrolnet class.The
from_pretrainedfunction returns a directory structure like this: controlnet, controlnet_1, controlnet_2,whereas
save_pretrainedis like this: controlnet, controlnet_1, controlnet_1_2.For example, when loading a saved model, if there are 3 controlnets, the last controlnet will not be loaded. (more than 2 always same issue)
Fixes#7814