Uh oh!
There was an error while loading. Please reload this page.
[Core] Refactor IPAdapterPlusImageProjection a bit - #7994
Conversation
HuggingFaceDocBuilderDev
commented
May 21, 2024
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
fabiorigano
commented
May 21, 2024
@sayakpaul no problem, it looks really good and neat to me now! |
fabiorigano
commented
May 21, 2024
@sayakpaul I tested both simple inference and the diffusers/tests/models/unets/test_models_unet_2d_condition.py Lines 162 to 175 in e1df77e IMO they should be either removed or updated. WDYT? |
sayakpaul
commented
May 22, 2024
Thanks for catching this, @fabiorigano! I just updated it in 9ebacf3. WDYT? |
fabiorigano
commented
May 22, 2024
Looks great! @sayakpaul |
sayakpaul
commented
May 29, 2024
Thanks to @fabiorigano once again for the suggestion and kind help. |
* use IPAdapterPlusImageProjectionBlock in IPAdapterPlusImageProjection * reposition IPAdapterPlusImageProjection * refactor complete? * fix heads param retrieval. * update test dict creation method.
What does this PR do?
Refer to #7988, thanks to @fabiorigano for the suggestion. Even though Fabio mentioned working on a PR for this, I had some free-time and thought I would do it. I hope that's okay with you, @fabiorigano?
In any case, would really appreciate your reviews here and if you could test this if you find some time, that would be of great help.
@rootonchair feel free to give it a look as well.