Skip to content

Remove unnecessary lines - #8569

Merged
yiyixuxu merged 19 commits into
huggingface:mainfrom
tolgacangoz:remove-unnecessary-line
Jul 8, 2024
Merged

Remove unnecessary lines#8569
yiyixuxu merged 19 commits into
huggingface:mainfrom
tolgacangoz:remove-unnecessary-line

Conversation

@tolgacangoz

@tolgacangoztolgacangoz commented Jun 15, 2024

Copy link
Copy Markdown
Contributor

They are unnecessary lines, aren't they? Self-assigned vars have been found with PLW0127.

@yiyixuxu@DN6

@tolgacangoztolgacangoz changed the title Remove unused lineRemove an unused lineJun 15, 2024
@tolgacangoztolgacangoz changed the title Remove an unused line[Tests] Remove an unused lineJun 15, 2024
@tolgacangoztolgacangoz changed the title [Tests] Remove an unused line[Tests] Remove unnecessary linesJun 15, 2024
@tolgacangoztolgacangoz changed the title [Tests] Remove unnecessary linesRemove unnecessary linesJun 15, 2024
@sayakpaul
sayakpaul requested a review from yiyixuxuJune 18, 2024 15:39
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul
sayakpaul requested a review from DN6June 29, 2024 13:00

@a-r-r-o-wa-r-r-o-w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for removing the unnecessary lines! i do not know the reasoning behind the duplicate assignments but if it's just a mistake, these changes look good to me. CI looks good as well (failing test seems unrelated)

@yiyixuxuyiyixuxu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tolgacangoz

Copy link
Copy Markdown
ContributorAuthor

Thanks for merging!

@tolgacangoz
tolgacangoz deleted the remove-unnecessary-line branch July 8, 2024 21:22
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* Remove unused line
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tolgacangoz@HuggingFaceDocBuilderDev@yiyixuxu@a-r-r-o-w@sayakpaul