Skip to content

[Core] remove resume_download from Hub related stuff - #8648

Merged
sayakpaul merged 10 commits into
mainfrom
remove-resume-download
Jul 18, 2024
Merged

[Core] remove resume_download from Hub related stuff#8648
sayakpaul merged 10 commits into
mainfrom
remove-resume-download

Conversation

@sayakpaul

@sayakpaulsayakpaul commented Jun 20, 2024

Copy link
Copy Markdown
Member

What does this PR do?

To not have to incur:

huggingface_hub/file_download.py:1132: FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use `force_download=True`.

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Jun 20, 2024

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Wauplin

This comment was marked as duplicate.

Sign in to view

Wauplin
Wauplin approved these changes Jun 26, 2024
View reviewed changes

@WauplinWauplin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of removing those @sayakpaul. I'm linking #7843 and #8267 which are related PRs (the ones that should have already removed the deprecation warnings). Removing resume_download altogether is even better since it'll also us to remove it from huggingface_hub in the future.

Last thing: do you want to remove resume_download mention from docstrings as well? We have this message for now but if we remove them already, then let's remove the docs as well?

@sayakpaul

sayakpaul commented Jun 26, 2024

Copy link
Copy Markdown
MemberAuthor

@Wauplin removed from docstrings as well.

Wauplin
Wauplin approved these changes Jun 26, 2024
View reviewed changes

@WauplinWauplin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DN6

DN6 commented Jul 17, 2024

Copy link
Copy Markdown
Collaborator

@sayakpaul We can merge once the conflicts are resolved here

@sayakpaul

sayakpaul commented Jul 18, 2024

Copy link
Copy Markdown
MemberAuthor

Failing tests are unrelated.

@sayakpaul
sayakpaul merged commit e02ec27 into mainJul 18, 2024
@sayakpaul
sayakpaul deleted the remove-resume-download branch July 18, 2024 04:18
Disty0 pushed a commit to Disty0/diffusers that referenced this pull request Jul 18, 2024
@sayakpaul@Disty0
[Core] removeresume_downloadfrom Hub related stuff (huggingface#8648
2b153a6
)
* remove resume_download
* fix: _fetch_index_file call.
* remove resume_download from docs.
sayakpaul added a commit that referenced this pull request Dec 23, 2024
@sayakpaul
[Core] removeresume_downloadfrom Hub related stuff (#8648)
11307ce
* remove resume_download
* fix: _fetch_index_file call.
* remove resume_download from docs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WauplinWauplinWauplin approved these changes
@DN6DN6Awaiting requested review from DN6
@yiyixuxuyiyixuxuAwaiting requested review from yiyixuxu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sayakpaul@HuggingFaceDocBuilderDev@DN6@Wauplin