Skip to content

[Alpha-VLLM Team] Add Lumina-T2X to diffusers - #8652

Merged
yiyixuxu merged 103 commits into
huggingface:mainfrom
PommesPeter:lumina
Jul 8, 2024
Merged

[Alpha-VLLM Team] Add Lumina-T2X to diffusers#8652
yiyixuxu merged 103 commits into
huggingface:mainfrom
PommesPeter:lumina

Conversation

@PommesPeter

@PommesPeterPommesPeter commented Jun 20, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Add Lumina-T2X to diffusers

Fixes#8652

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@PommesPeterPommesPeter mentioned this pull request Jun 20, 2024
2 tasks
@PommesPeterPommesPeter changed the title Add Lumina-T2X to diffusers[WIP] Add Lumina-T2X to diffusersJun 20, 2024
Comment threadsrc/diffusers/models/transformers/lumina_nextdit2d.py Outdated
@yiyixuxu

Copy link
Copy Markdown
Collaborator

can you run make fix-copies again?

@PommesPeter

Copy link
Copy Markdown
ContributorAuthor

can you run make fix-copies again?

run it~

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu

Copy link
Copy Markdown
Collaborator

@PommesPeter lumina tests still fail
I think we need to update the lumina tests now because we made updates to the model

@PommesPeter

Copy link
Copy Markdown
ContributorAuthor

@PommesPeter lumina tests still fail I think we need to update the lumina tests now because we made updates to the model

yep, we have fixed the problem from test class.

@yiyixuxu

Copy link
Copy Markdown
Collaborator

@PommesPeter we need the make style again, sorry!

Comment threadtests/pipelines/lumina/test_lumina_nextdit.py Outdated
Comment threadtests/pipelines/lumina/test_lumina_nextdit.py Outdated
@vladmandic

vladmandic commented Jul 6, 2024

Copy link
Copy Markdown
Contributor

not sure what's the status of the pr since simple load is still failing?

pip install git+https://github.com/PommesPeter/diffusers@lumina

importtorchfromdiffusersimportLuminaText2ImgPipelinepipe=LuminaText2ImgPipeline.from_pretrained("Alpha-VLLM/Lumina-Next-SFT-diffusers", torch_dtype=torch.bfloat16).cuda()
ValueError: Cannot load <class 'diffusers.models.transformers.lumina_nextdit2d.LuminaNextDiT2DModel'> from /mnt/models/Diffusers/models--Alpha-VLLM--Lumina-Next-SFT-diffusers/snapshots/f82702c1b6a9bac3db9155edad1fd8dbf088cdf6/transformer because the following keys are missing:
...

@PommesPeter

Copy link
Copy Markdown
ContributorAuthor

not sure what's the status of the pr since simple load is still failing?

pip install git+https://github.com/PommesPeter/diffusers@lumina

importtorchfromdiffusersimportLuminaText2ImgPipelinepipe=LuminaText2ImgPipeline.from_pretrained("Alpha-VLLM/Lumina-Next-SFT-diffusers", torch_dtype=torch.bfloat16).cuda()
ValueError: Cannot load <class 'diffusers.models.transformers.lumina_nextdit2d.LuminaNextDiT2DModel'> from /mnt/models/Diffusers/models--Alpha-VLLM--Lumina-Next-SFT-diffusers/snapshots/f82702c1b6a9bac3db9155edad1fd8dbf088cdf6/transformer because the following keys are missing:
...

sorry, we have network problem in pushing our newest model to huggingface. I'm re-pushing the newest model for lumina.

@PommesPeter

Copy link
Copy Markdown
ContributorAuthor

not sure what's the status of the pr since simple load is still failing?

pip install git+https://github.com/PommesPeter/diffusers@lumina

importtorchfromdiffusersimportLuminaText2ImgPipelinepipe=LuminaText2ImgPipeline.from_pretrained("Alpha-VLLM/Lumina-Next-SFT-diffusers", torch_dtype=torch.bfloat16).cuda()
ValueError: Cannot load <class 'diffusers.models.transformers.lumina_nextdit2d.LuminaNextDiT2DModel'> from /mnt/models/Diffusers/models--Alpha-VLLM--Lumina-Next-SFT-diffusers/snapshots/f82702c1b6a9bac3db9155edad1fd8dbf088cdf6/transformer because the following keys are missing:
...

sorry, we have network problem in pushing our newest model to huggingface. I'm re-pushing the newest model for lumina.

Hi @vladmandic
we have pushed our model to huggingface repo. could you re-pull the huggingface model repo for testing you want?

@yiyixuxu

Copy link
Copy Markdown
Collaborator

@PommesPeter
can you check if you need to update the slow tests? since the checkpoints have been updated a couple of times
I will merge it tomorrow once the slow tests are updated

@PommesPeter

Copy link
Copy Markdown
ContributorAuthor

@PommesPeter can you check if you need to update the slow tests? since the checkpoints have been updated a couple of times I will merge it tomorrow once the slow tests are updated

okay, i will fix the problem.

@vladmandic

vladmandic commented Jul 6, 2024

Copy link
Copy Markdown
Contributor

@PommesPeter confirmed as working with updated model on hf.

Comment threadtests/pipelines/lumina/test_lumina_nextdit.py
@yiyixuxu
yiyixuxu merged commit 9838867 into huggingface:mainJul 8, 2024
@yiyixuxu

Copy link
Copy Markdown
Collaborator

merged! thank you!

@PommesPeter

Copy link
Copy Markdown
ContributorAuthor

wow! thank you for your reviewing to our pr

@ylacombeylacombe mentioned this pull request Jul 10, 2024
5 tasks
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
---------
Co-authored-by: zhuole1025 <zhuole1025@gmail.com>
Co-authored-by: YiYi Xu <yixu310@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@PommesPeter@zhuole1025@yiyixuxu@HuggingFaceDocBuilderDev@vladmandic