Skip to content

Fix static typing and doc typos - #8807

Merged
yiyixuxu merged 2 commits into
huggingface:mainfrom
zhuoqun-chen:fix_typos
Jul 8, 2024
Merged

Fix static typing and doc typos#8807
yiyixuxu merged 2 commits into
huggingface:mainfrom
zhuoqun-chen:fix_typos

Conversation

@zhuoqun-chen

@zhuoqun-chenzhuoqun-chen commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes typos:

  • 1 return type doc string typo in scheduling_ddim.py
  • 1 static type checking typo in scheduling_ddpm.py

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

a-r-r-o-w
a-r-r-o-w approved these changes Jul 8, 2024
View reviewed changes

@a-r-r-o-wa-r-r-o-w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution! Looks correct to me, but might require a few minor changes in other files with make fix-copies

cc @sayakpaul

Comment threadsrc/diffusers/schedulers/scheduling_ddpm.py
timestep_spacing: str = "leading",
steps_offset: int = 0,
rescale_betas_zero_snr: int = False,
rescale_betas_zero_snr: bool = False,

@a-r-r-o-wa-r-r-o-wJul 8, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have to run make fix-copies to fix all instances of this type hint. If you find more inconsistencies, please feel free to open follow-up PRs!

@zhuoqun-chenzhuoqun-chenJul 8, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @a-r-r-o-w for the information! I just make fix-copies and made a follow-up commit that corrects another file scheduling_ddpm_parallel.py.

@a-r-r-o-w
a-r-r-o-w requested a review from yiyixuxuJuly 8, 2024 18:34
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Jul 8, 2024

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu
yiyixuxu merged commit 70611a1 into huggingface:mainJul 8, 2024
@yiyixuxu

yiyixuxu commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

thanks for your contribution!

@zhuoqun-chen

zhuoqun-chen commented Jul 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you @a-r-r-o-w and @yiyixuxu for reviewing and merging this PR! Have a nice day!

sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
@zhuoqun-chen@sayakpaul
Fix static typing and doc typos (#8807)
043d98f
* Fix static typing and doc typos
* Fix more same type hint typos with make fix-copies
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxuyiyixuxuAwaiting requested review from yiyixuxu
1 more reviewer
@a-r-r-o-wa-r-r-o-wa-r-r-o-w approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhuoqun-chen@HuggingFaceDocBuilderDev@yiyixuxu@a-r-r-o-w