Skip to content

make deps_table_update to fix CI tests - #9720

Merged
sayakpaul merged 6 commits into
mainfrom
fix-dependecy-versions
Oct 21, 2024
Merged

make deps_table_update to fix CI tests#9720
sayakpaul merged 6 commits into
mainfrom
fix-dependecy-versions

Conversation

@a-r-r-o-w

@a-r-r-o-wa-r-r-o-w commented Oct 19, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

We missed this step (I did not know we had to do it) in #9709. Also contains a dummy change for now to trigger CI fast tests

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul@DN6

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Oct 19, 2024

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@a-r-r-o-w

a-r-r-o-w commented Oct 19, 2024

Copy link
Copy Markdown
ContributorAuthor

@sayakpaul, seems like capping the torch version in diffusers to <2.5.0 does not fix the failing tests, because 2.5 gets installed by peft (see here).

@sayakpaul

sayakpaul commented Oct 20, 2024

Copy link
Copy Markdown
Member

I am not sure if that is the case because from the logs of that action, I don't see any reinstallations of PyTorch, though.

To confirm things, I would try print the PyTorch version just after the container is initialized. After this line:

diffusers/.github/workflows/pr_test_peft_backend.yml

Line 94 in 56d6d21

python -m uv pip install -e [quality,test]

If it's 2.5.0, then there's something wrong.

@sayakpaul

sayakpaul commented Oct 20, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Hmm I am pretty sure that the updated Torch is coming from

diffusers/docker/diffusers-pytorch-cpu/Dockerfile

Line 32 in 56d6d21

torch \

So, we need to:

  • Pin torch versions in the Dockerfiles
  • Verify Dockerfiles build
  • Trigger a Docker build and push workflow

Just pinning in the setup.py file won't cut it and my bad it went unnoticed.

@sayakpaulsayakpaul mentioned this pull request Oct 20, 2024
Merged
@sayakpaul

sayakpaul commented Oct 20, 2024

Copy link
Copy Markdown
Member

PR: #9709

Workflow: https://github.com/huggingface/diffusers/actions/runs/11423669772

@sayakpaul
sayakpaul requested a review from DN6October 20, 2024 06:37
@sayakpaulsayakpaul mentioned this pull request Oct 21, 2024
Merged
8 tasks
DN6
DN6 approved these changes Oct 21, 2024
View reviewed changes
@sayakpaul
sayakpaul merged commit 24281f8 into mainOct 21, 2024
@sayakpaul
sayakpaul deleted the fix-dependecy-versions branch October 21, 2024 04:28
sayakpaul added a commit that referenced this pull request Dec 23, 2024
@a-r-r-o-w@sayakpaul
make deps_table_updateto fix CI tests (#9720)
f566421
* update
* dummy change to trigger CI; will revert
* no deps peft
* np deps
* todo
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DN6DN6DN6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a-r-r-o-w@HuggingFaceDocBuilderDev@sayakpaul@DN6