Uh oh!
There was an error while loading. Please reload this page.
[bitsandbbytes] follow-ups - #9730
Merged
Merged
Conversation
sayakpaul
marked this pull request as draft
October 21, 2024 05:50
HuggingFaceDocBuilderDev
commented
Oct 21, 2024
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
marked this pull request as ready for review
October 21, 2024 10:18
DN6
reviewed
Oct 21, 2024
| """ | ||
| checks if the quantized param has expected shape. | ||
| """ | ||
| if not hasattr(self, "check_quantized_param_shape"): |
Collaborator
There was a problem hiding this comment.
Think this should be?
Suggested change
| ifnothasattr(self, "check_quantized_param_shape"): | |
| ifnothasattr(self, "check_if_quantized_param"):: |
Collaborator
There was a problem hiding this comment.
The method is checking for itself? That can't be the case right? Because the subclass inherits it? So it should already be in there?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
sayakpaul
commented
Oct 22, 2024
| quantization_config=quantization_config | ||
| ) | ||
| ``` | ||
| Once a model is quantized, you can push the model to the Hub with the [`~ModelMixin.push_to_hub`] method. The quantization `config.json` file is pushed first, followed by the quantized model weights. You can also save the serialized 4-bit models locally with [`~ModelMixin.save_pretrained`]. |
MemberAuthor
There was a problem hiding this comment.
To unify the content between 8bit and 4bit hfoption.
sayakpaul
commented
Oct 22, 2024
| and hf_quantizer.check_if_quantized_param(model, param, param_name, state_dict, param_device=device) | ||
| ): | ||
| hf_quantizer.check_quantized_param_shape(param_name, empty_state_dict[param_name].shape, param.shape) | ||
| elif not is_quant_method_bnb: |
MemberAuthor
There was a problem hiding this comment.
Could have done with else but I think it's a tad bit safer.
DN6
approved these changes
Oct 22, 2024
sayakpaul added a commit
that referenced
this pull request
Dec 23, 2024
* bnb follow ups. * add a warning when dtypes mismatch. * fx-copies * clear cache. * check_if_quantized_param * add a check on shape. * updates * docs * improve readability. * resources. * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
bitsandbytes#9213 (comment)hf-internal-testing