Skip to content

added camera FPS settings to recording and inference instead of hardcoded 30fps, naming #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bellabzhu wants to merge 6 commits into from
Closed

added camera FPS settings to recording and inference instead of hardcoded 30fps, naming #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40df15d
feat(frontend): add editable Camera FPS field to inference modal
bellabzhu Sep 8, 2026
12e12d0
Merge pull request #1 from bellabzhu/feat/inference-camera-fps
bellabzhu Sep 11, 2026
e1d811a
feat(frontend): brand the landing header and browser tab as LeLab-Bellab
bellabzhu Sep 11, 2026
ce1cdd8
Merge pull request #2 from bellabzhu/feat/bellab-branding
bellabzhu Sep 11, 2026
6f79d95
fix(frontend): stop hard-coding recording fps to 30
bellabzhu Sep 11, 2026
adcc7db
Merge pull request #3 from bellabzhu/feat/recording-fps
bellabzhu Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,958 changes: 3,958 additions & 0 deletions frontend/dist/assets/index-BSR2sc3Q.js
View file
Open in desktop

Large diffs are not rendered by default.

3,958 changes: 0 additions & 3,958 deletions frontend/dist/assets/index-Cl3yeJ80.js
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions frontend/dist/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>LeLab</title>
<title>LeLab-Bellab</title>
<link rel="icon" type="image/x-icon" href="/favicon.ico" />
<meta name="description" content="LeRobot but on your browser." />

<meta property="og:title" content="LeLab" />
<meta property="og:title" content="LeLab-Bellab" />
<meta property="og:description" content="LeRobot but on your browser." />
<meta property="og:type" content="website" />
<script type="module" crossorigin src="/assets/index-Cl3yeJ80.js"></script>
<script type="module" crossorigin src="/assets/index-BSR2sc3Q.js"></script>
<link rel="stylesheet" crossorigin href="/assets/index-1vZ-UTJX.css">
</head>

Expand Down
4 changes: 2 additions & 2 deletions frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>LeLab</title>
<title>LeLab-Bellab</title>
<link rel="icon" type="image/x-icon" href="/favicon.ico" />
<meta name="description" content="LeRobot but on your browser." />

<meta property="og:title" content="LeLab" />
<meta property="og:title" content="LeLab-Bellab" />
<meta property="og:description" content="LeRobot but on your browser." />
<meta property="og:type" content="website" />
</head>
Expand Down
17 changes: 16 additions & 1 deletion frontend/src/components/landing/InferenceModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ const InferenceModal: React.FC<Props> = ({
const [selectedStep, setSelectedStep] = useState<number | null>(initialStep);
const [task, setTask] = useState("");
const [durationS, setDurationS] = useState(60);
const [cameraFps, setCameraFps] = useState(DEFAULT_FPS);
const [submitting, setSubmitting] = useState(false);

const [policyConfig, setPolicyConfig] = useState<PolicyConfigSummary | null>(null);
Expand Down Expand Up @@ -222,7 +223,7 @@ const InferenceModal: React.FC<Props> = ({
camera_index: idx,
width: dims.width,
height: dims.height,
fps: DEFAULT_FPS,
fps: cameraFps,
};
}
try {
Expand Down Expand Up @@ -356,6 +357,20 @@ const InferenceModal: React.FC<Props> = ({
className="bg-gray-800 border-gray-700 text-white"
/>
</div>
<div className="space-y-2">
<Label htmlFor="cameraFps" className="text-sm font-medium text-gray-300">
Camera FPS
</Label>
<NumberInput
id="cameraFps"
min={1}
value={cameraFps}
onChange={(v) => {
if (v !== undefined) setCameraFps(v);
}}
className="bg-gray-800 border-gray-700 text-white"
/>
</div>
</div>

<div className="space-y-4">
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/landing/LandingTopBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ const LandingTopBar: React.FC = () => {
<div className="flex items-center gap-2">
<img
src="/lovable-uploads/5e648747-34b7-4d8f-93fd-4dbd00aeeefc.png"
alt="LeLab"
alt="LeLab-Bellab"
className="h-7 w-7"
/>
<span className="text-base font-semibold tracking-tight text-white">
LeLab
LeLab-Bellab
</span>
</div>
<div className="flex items-center gap-2">
Expand Down
25 changes: 25 additions & 0 deletions frontend/src/components/landing/RecordingModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ interface RecordingModalProps {
setEpisodeTimeS: (value: number) => void;
resetTimeS: number;
setResetTimeS: (value: number) => void;
recordingFps: number;
setRecordingFps: (value: number) => void;
streamingEncoding: boolean;
setStreamingEncoding: (value: boolean) => void;
cameras: CameraConfig[];
Expand All @@ -60,6 +62,8 @@ const RecordingModal: React.FC<RecordingModalProps> = ({
setEpisodeTimeS,
resetTimeS,
setResetTimeS,
recordingFps,
setRecordingFps,
streamingEncoding,
setStreamingEncoding,
cameras,
Expand Down Expand Up @@ -195,6 +199,27 @@ const RecordingModal: React.FC<RecordingModalProps> = ({
className="bg-gray-800 border-gray-700 text-white"
/>
</div>
<div className="space-y-2">
<Label
htmlFor="recordingFps"
className="text-sm font-medium text-gray-300"
>
Recording FPS
</Label>
<NumberInput
id="recordingFps"
min="1"
value={recordingFps}
onChange={(v) => {
if (v !== undefined) setRecordingFps(v);
}}
className="bg-gray-800 border-gray-700 text-white"
/>
<p className="text-xs text-gray-500">
Must match the cameras&apos; own fps below, or recording
will fail.
</p>
</div>
<div className="grid grid-cols-2 gap-4">
<div className="space-y-2">
<Label
Expand Down
10 changes: 8 additions & 2 deletions frontend/src/pages/Landing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ const Landing = () => {
const [numEpisodes, setNumEpisodes] = useState(5);
const [episodeTimeS, setEpisodeTimeS] = useState(60);
const [resetTimeS, setResetTimeS] = useState(15);
const [recordingFps, setRecordingFps] = useState(30);
const [streamingEncoding, setStreamingEncoding] = useState(true);
const [cameras, setCameras] = useState<CameraConfig[]>([]);

Expand Down Expand Up @@ -74,7 +75,10 @@ const Landing = () => {
}, []);

const openRecordingModal = () => {
setCameras(selectedRecord ? [...(selectedRecord.cameras ?? [])] : []);
const robotCameras = selectedRecord ? [...(selectedRecord.cameras ?? [])] : [];
setCameras(robotCameras);
const cameraFps = robotCameras.find((c) => c.fps)?.fps;
setRecordingFps(cameraFps ?? 30);
setShowRecordingModal(true);
};

Expand Down Expand Up @@ -207,7 +211,7 @@ const Landing = () => {
num_episodes: numEpisodes,
episode_time_s: episodeTimeS,
reset_time_s: resetTimeS,
fps: 30,
fps: recordingFps,
video: true,
push_to_hub: false,
resume: false,
Expand Down Expand Up @@ -313,6 +317,8 @@ const Landing = () => {
setEpisodeTimeS={setEpisodeTimeS}
resetTimeS={resetTimeS}
setResetTimeS={setResetTimeS}
recordingFps={recordingFps}
setRecordingFps={setRecordingFps}
streamingEncoding={streamingEncoding}
setStreamingEncoding={setStreamingEncoding}
cameras={cameras}
Expand Down