Fix logging call that hides why torch.compile failed - #1387
Open
David-Wu1119 wants to merge 1 commit into
Open
David-Wu1119 wants to merge 1 commit into
David-Wu1119 wants to merge 1 commit into
Conversation
logger.warning("Could not compile the model because: ", e) passes the
exception as a logging argument for a message with no placeholder, so
logging raises internally: the warning is never emitted and stderr gets a
"--- Logging error ---" traceback instead. The reason compilation failed,
which is the point of the message, is lost.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
config.compileis set andmodel.compile()raisesAttributeError, the warning that should explain why is never logged:The message has no placeholder, so
loggingtreatseas an unused argument and raises while formatting the record. The user gets a--- Logging error ---traceback on stderr instead of the warning, and the actual reason is dropped:With
%sthe record is emitted normally:ruff checkandruff format --checkpass on the file.🤖 Generated with Claude Code