Skip to content

Use config_dict_or_path for deepspeed.zero.Init - #13614

Merged
stas00 merged 1 commit into
huggingface:masterfrom
aphedges:fix-zero-init
Sep 17, 2021
Merged

stas00 merged 1 commit into
huggingface:masterfrom
aphedges:fix-zero-init

Conversation

@aphedges

Copy link
Copy Markdown
Contributor

What does this PR do?

While #13587 fixes one DeepSpeed warning, it missed a similar one. This applies the same change of config -> config_dict_or_path in another location.

Who can review?

@sgugger (same reviewer as #13587)

@sgugger sgugger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger

sgugger commented Sep 17, 2021

Copy link
Copy Markdown
Collaborator

I'll let @stas00 merge this after he double-checks it's good :-)

@sgugger
sgugger requested a review from stas00 September 17, 2021 11:27

@stas00 stas00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this omission, @aphedges!

@stas00
stas00 merged commit ce32c69 into huggingface:master Sep 17, 2021
@aphedges

Copy link
Copy Markdown
Contributor Author

@stas00, you're welcome! Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants