Conversation
Previously, when syncing weights to vLLM we only reset the prefix cache, so the encoder cache still has image embeddings computed by the previous policy. Now reset the encoder cache in sync_weights, in both server and colocate modes. Added `reset_encoder_cache` method to `VLLMClient`. `VLLMClient._post` now returns an empty dict if the response has no content. Necessary for `/reset_encoder_cache`. Resolves: huggingface#7198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7198
Previously, when syncing weights to vLLM, only the prefix cache is cleared, while the image encoder cache still has image embeddings computed by the previous policy.
Now, we reset the encoder cache in
sync_weights, in both server and colocate mode.Added
reset_encoder_cachemethod toVLLMClient.VLLMClient._postnow returns an empty dict if the response has no content. Necessary for/reset_encoder_cache.Before submitting
AI writing disclosure
We welcome the use of AI tools to help with contributions. For transparency and to help us improve our review process, please indicate the level of AI involvement in this PR.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
Note
Medium Risk
Targets multimodal vLLM training correctness after weight updates; small HTTP client change affects any empty-body POST responses.
Overview
Clears stale vision encoder embeddings in vLLM after training weights are pushed, not just the KV prefix cache.
VLLMClientaddsreset_encoder_cache()(POST/reset_encoder_cache) and makes_postreturn{}when the response body is empty so that endpoint does not break JSON parsing.Weight sync in
VLLMGeneration.sync_weightsandOnlineDPOTrainer._move_model_to_vllmnow calls encoder cache reset alongsidereset_prefix_cachein both server (vllm_client) and colocate (llm_engine.reset_encoder_cache) modes.Integration tests mirror
test_reset_prefix_cachewithtest_reset_encoder_cacheon the vLLM client/server suites.Reviewed by Cursor Bugbot for commit ba72bd6. Bugbot is set up for automated code reviews on this repo. Configure here.