Uh oh!
There was an error while loading. Please reload this page.
Token claims and vesting runtime tests - #445
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Looks good so far, but a couple of changes are required.
- the
switch_blockhelper doesn't look right, we should probably invoke a more realistic block switching or none at all - the calls are tests via direct invocation, which doesn't test the signed ext, which we should do; I'll add the corresponding entries to the todo list
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7c5b8bc to
e12449aCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
MOZGIII
left a comment
There was a problem hiding this comment.
Great! Now I'll do a more thorough review on this code once again, and either request more changes or we'll be good to merge.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Tests for direct calls need to test for the errors too. Errors have to be tested for:
- direct calls
- dispatch validate
- dispatch pre/post
These three implementations are potentially different, so we need to ensure each of them handles errors (in their own way) correctly.
But still, to clarify, no tests for individual SignedExtensions are needed, only for the combined SignedExtra.
d4d234e to
a0fa379Compare
Runtime tests for token claims and vesting integration paritytech/substrate#441 .
To do
claimcall: claiming without vesting works:claimcall: claiming with vesting worksunlockcall: unlocking partial balance worksunlockcall: unlocking full balance worksclaimtransactionclaimtransactions, preventing them getting into the transaction pool