Uh oh!
There was an error while loading. Please reload this page.
[3.x] Remove check for deprecated Laravel Mix command flags - #2461
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## v3-dev #2461 +/- ##
===========================================
Coverage 100.00% 100.00% Complexity 2007 2007 ===========================================
Files 197 197 Lines 5145 5144 -1 ===========================================
- Hits 5145 5144 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR finalizes the v3 removal of legacy Laravel Mix-era flags for the build console command by deleting the placeholder options and the helper that emitted a custom deprecation/error message, aligning the CLI surface area around --vite.
Changes:
- Removed
--run-dev/--run-prodoptions from thebuildcommand signature. - Removed the
checkForDeprecatedRunMixCommandUsage()helper and its invocation. - Documented the cleanup in the HydePHP v3 planning document.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/framework/src/Console/Commands/BuildSiteCommand.php | Removes deprecated Mix-era CLI options and the legacy deprecation handler from the build command. |
| HYDEPHP_V3_PLANNING.md | Notes the removal as part of v3 minor cleanup/planning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Remove checkForDeprecatedRunMixCommandUsage and deprecated --run-dev/--run-prod options These Mix-era options were deprecated in v2.0 and are being fully removed for v3. The --vite flag supersedes them.
ac62f2b to
e4e2553CompareUh oh!
There was an error while loading. Please reload this page.
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Removed the
checkForDeprecatedRunMixCommandUsagehelper and deprecated --run-dev/--run-prod optionsThese Mix-era options were deprecated in v2.0 and are being fully removed for v3. The --vite flag supersedes them.