Skip to content

[3.x] Remove check for deprecated Laravel Mix command flags - #2461

Merged
emmadesilva merged 1 commit into
v3-devfrom
v3/remove-deprecated-run-mix-command-check
Jun 28, 2026
Merged

[3.x] Remove check for deprecated Laravel Mix command flags#2461
emmadesilva merged 1 commit into
v3-devfrom
v3/remove-deprecated-run-mix-command-check

Conversation

@emmadesilva

@emmadesilvaemmadesilva commented Jun 28, 2026

Copy link
Copy Markdown
Member

Removed the checkForDeprecatedRunMixCommandUsage helper and deprecated --run-dev/--run-prod options

These Mix-era options were deprecated in v2.0 and are being fully removed for v3. The --vite flag supersedes them.

@emmadesilva
emmadesilva requested a review from CopilotJune 28, 2026 16:22
@emmadesilva
emmadesilva marked this pull request as ready for review June 28, 2026 16:23
@codecov

codecovBot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d4328f1) to head (e4e2553).

Additional details and impacted files
@@ Coverage Diff @@## v3-dev #2461 +/- ##
===========================================
Coverage 100.00% 100.00% Complexity 2007 2007 ===========================================
Files 197 197 Lines 5145 5144 -1 ===========================================
- Hits 5145 5144 -1 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR finalizes the v3 removal of legacy Laravel Mix-era flags for the build console command by deleting the placeholder options and the helper that emitted a custom deprecation/error message, aligning the CLI surface area around --vite.

Changes:

  • Removed --run-dev / --run-prod options from the build command signature.
  • Removed the checkForDeprecatedRunMixCommandUsage() helper and its invocation.
  • Documented the cleanup in the HydePHP v3 planning document.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
packages/framework/src/Console/Commands/BuildSiteCommand.phpRemoves deprecated Mix-era CLI options and the legacy deprecation handler from the build command.
HYDEPHP_V3_PLANNING.mdNotes the removal as part of v3 minor cleanup/planning.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadHYDEPHP_V3_PLANNING.md
Remove checkForDeprecatedRunMixCommandUsage and deprecated --run-dev/--run-prod options
These Mix-era options were deprecated in v2.0 and are being fully removed for v3. The --vite flag supersedes them.
@emmadesilva
emmadesilvaforce-pushed the v3/remove-deprecated-run-mix-command-check branch from ac62f2b to e4e2553CompareJune 28, 2026 16:29
@emmadesilva
emmadesilva merged commit 69fdf95 into v3-devJun 28, 2026
7 checks passed
@emmadesilva
emmadesilva deleted the v3/remove-deprecated-run-mix-command-check branch June 28, 2026 16:38
emmadesilva added a commit that referenced this pull request Jun 28, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jun 28, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 3, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 3, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 3, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 3, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 4, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 4, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 8, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 9, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 10, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 10, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
emmadesilva added a commit that referenced this pull request Jul 11, 2026
Merge pull request #2461 from hydephp/v3/remove-deprecated-run-mix-command-check
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@emmadesilva