Uh oh!
There was an error while loading. Please reload this page.
[3.x] Revert generated robots.txt and llms.txt (stacked PR 6 and PR 7) - #2580
Merged
Merged
Conversation
Deletes the feature-specific generator/page test classes and drops the now dead hyde.robots/hyde.llms config toggles from collection and manifest tests that only needed them to keep exact-count assertions accurate.
Hyde no longer generates these files automatically, so drop the generator customization example, the config reference, and the feature mentions in the generated-discovery-files and build-tasks docs. Illustrative uses of robots.txt as an example non-HTML filename (InMemoryPage output inference, showInSitemap()) are unaffected and stay.
Drops the upgrade steps and checklist items for features that no longer exist on this branch, and renumbers the subsequent upgrade steps. Removes the corresponding HYDEPHP_V3_PLANNING.md changelog entries.
Marks PR 6 and PR 7 as reverted rather than implemented, replaces their implementation notes (which described deleted code as existing) with a short record of what was reverted and why, and fixes downstream references that claimed the D5 user-override paths were verified for both pages.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## v3/non-html-pages #2580 +/- ##
=====================================================
Coverage 100.00% 100.00% + Complexity 1824 1792 -32
=====================================================
Files 184 182 -2 Lines 4539 4453 -86 =====================================================
- Hits 4539 4453 -86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts both #2531 (generated
robots.txt) and #2534 (generatedllms.txt). Both were overengineered; they're being redesigned from scratch, starting from a clean baseline instead of iterating on top of the current implementation.llms.txt is included in the same PR rather than a separate one because it was explicitly built "wired like robots.txt" — reverting only one would have left the epic and several docs full of references to a sibling feature that no longer exists.
RobotsTxtGenerator,LlmsTxtGenerator, theirFeatures::hasRobotsTxt()/hasLlmsTxt()gates,HydeCoreExtensionwiring, and thehyde.robots/hyde.llmsconfig blocks (kept in lockstep betweenconfig/hyde.phpand the framework config stub).hyde.robots.enabled/hyde.llms.enabledtoggles out of collection/manifest/realtime-compiler tests that only needed them to keep exact-count assertions accurate.customization.md,build-tasks.md,in-memory-pages.md) andUPGRADE.md/HYDEPHP_V3_PLANNING.md. Illustrative uses ofrobots.txtas an example non-HTML filename (InMemoryPageoutput inference,showInSitemap()) are untouched — those describe PR 1/PR 4 behavior, not the reverted generators.EPIC_NON_HTML_PAGES.md: PR 6 and PR 7 are marked reverted rather than implemented, their implementation notes (which described deleted code as existing) replaced with a short record of what was tried and why it was cut, and downstream references that claimed the D5 user-override paths were verified for both pages are corrected.Test plan
vendor/bin/pest --testsuite FeatureFramework,UnitFramework,FeatureHyde,"Realtime Compiler"— ran before and after the revert; identicalFAILEDoutput both times (only the known pre-existingFeaturedImageUnitTestPHP 8.5 failure)php monorepo/HydeStan/run.php— no errorsconfig/hyde.phpandpackages/framework/config/hyde.phpstay in lockstep (HydeConfigFilesAreMatchingTest)