Uh oh!
There was an error while loading. Please reload this page.
Remove stray generated .d.ts committed under hypaware-core - #186
Merged
Conversation
blob-io.d.ts and maintenance.d.ts were emitted in-place by an early rootDir=src declaration-build experiment (those hypaware-core modules fell outside the emit root, so tsc wrote their declarations next to the source) and got swept into #185 by git add -A. They shadow the JSDoc and are build cruft. The shipped build emits only to types/ and, with the core_commands dynamic import indirected, no longer pulls these hypaware-core modules into the src emit, so removing them is safe: typecheck, build:types (does not regenerate them), and tests (1473 pass) all stay green.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blob-io.d.tsandmaintenance.d.tswere accidentally committed in #185. They were emitted in-place by an earlyrootDir=srcdeclaration-build experiment (thosehypaware-coremodules fell outside the emit root, so tsc wrote.d.tsnext to the source), then swept in bygit add -A. They shadow the JSDoc and are build cruft, not source.The shipped build emits only to
types/, and with thecore_commandsdynamic import indirected, the build no longer pulls thesehypaware-coremodules into thesrcemit. Removing them is safe:typecheck,build:types(does not regenerate them), andnpm test(1473 pass) all stay green.