Uh oh!
There was an error while loading. Please reload this page.
Remove dead code: unused exports - #190
Merged
Merged
Conversation
…lugins Delete seven exported functions with zero references anywhere in the repo (verified across .js, .json, .ts, .md), plus the now-orphaned imports and a stale comment that referenced one of them: - pluginInstallRoot (src/core/plugin_install/paths.js) - statusLogDir and the platformIsSupported re-export (src/core/daemon/status.js) - stopServiceDaemon (src/core/daemon/install.js) - isAttached (codex plugin settings.js) + orphaned isManagedAttached import - clearAiGatewayRuntime, clearGraphRuntime, clearGascityRuntime (plugin runtimes) The three clearXxxRuntime functions were leftover teardown stubs never wired into activation/deactivation. statusLogDir and the platformIsSupported re-export existed only "for symmetry" and had no callers. Tests, lint, and typecheck all pass.
platypii
commented
Jun 29, 2026
ContributorAuthor
Code review (high effort) — cleanRan a recall-biased review focused on the angles that matter for a deletion-only diff: removed-behavior, cross-file references, and orphaned imports. Result: no findings. Verified grep-backed:
Checks: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes seven exported functions that have zero references anywhere in the repository (verified across
.js,.json,.ts,.md, excludingnode_modulesandllp/), along with imports and a comment orphaned by the deletions.pluginInstallRootsrc/core/plugin_install/paths.jspluginInstallDircovers real usestatusLogDirsrc/core/daemon/status.jsplatformIsSupportedre-exportsrc/core/daemon/status.jsstatusLogDir; nobody imports it from herestopServiceDaemonsrc/core/daemon/install.jsisAttachedsettings.jsclearAiGatewayRuntimeruntime.jsclearGraphRuntimeruntime.jsclearGascityRuntimeruntime.jsAlso removed now-orphaned imports (
defaultLogDir,platformIsSupportedin status.js;isManagedAttachedin codex settings.js) and fixed the stale gascity comment.Checks
npm test— 1485 pass, 0 failnpm run lint— cleannpm run typecheck— cleanFirst of three planned cleanup PRs (dead code, then em dashes, then type-import specifiers).