CLI cleanup: split core_commands, unify argv parsing, delete the dead walkthrough

[platypii]

Option C from the complexity review, plus the kernel-types rename requested along the way. Six commits, each reviewable on its own:

1. Delete the dead legacy walkthrough (−300). runWalkthrough/composeConfig had no production callers since the picker replaced them; the one smoke flow that drove the legacy path headlessly (only to validate the span contract) now drives the picker and asserts the picker's span shape.

2. Split core_commands.js into per-topic modules (4,597 → 370 lines). Implementations move verbatim to src/core/commands/{status,query,plugin,config,daemon,mcp,misc,sink,init,central,clients}.js, next to the existing backfill.js; core_commands.js keeps the registry table. This also breaks the core_commands ↔ remote_commands import cycle (remote_commands now reaches enrollCentralSink via commands/central.js). Five imports referenced only in comments/usage strings were dropped; parseMcpArgv is no longer exported (no users).

3. Test-fixture fix: the config-apply-deps git fixture now disables tag/commit signing so a host-level tag.gpgsign=true cannot break npm test.

4. Unify argv parsing on the verb codec (−139 net). Eleven commands hand-rolled their own argv loops with divergent --flag=value support, error wording, and help handling. New parseCommandArgv() wraps the existing schema-driven argvToParams with the two command conventions verbs don't need: -h/--help detection and short-alias expansion. Two backwards-compatible codec generalizations: greedy array positionals (hyp backfill claude codex) and items.enum. Migrated: query maintain, sink maintain, plugin install/update, config validate, daemon install/run, mcp, ignore, skills, join, leave, init, backfill run/plan. Kept bespoke: attach/detach's client parser (positional-or-flag merge with consistency check) and the five plugin-internal parsers (need a public codec export; follow-up).

5. Dedupe stray helpers (−51). safeOrigin existed three times (canonical originOf now exported from gateway_seed); readAllStdin/isObject in remote_commands replaced by the shared stdio.js/isPlainObject; duplicated copyDir moved to src/core/util/fs_copy.js.

6. Rename collectivus-plugin-kernel-types.d.ts → hypaware-plugin-kernel-types.d.ts (264 files, mechanical). The header itself said the name was only pending the project rename; no public import specifier contained it. Tombstoned LLPs and prose about collectivus-the-project untouched.

Behavior deltas (flagged deliberately)

• Every migrated command now accepts --flag=value uniformly (several previously accepted only the space form).
• Parse-error texts unify on the codec's wording, e.g. unknown flag --x (previously a mix of unknown flag '--x', unknown argument: --x, flag --x requires a value). Two test assertions updated to match.
• --help anywhere in argv now wins over parse errors (previously only when it preceded the bad token). hyp plugin install --help now prints usage instead of treating --help as a source name.
• hyp init --client claude,codex (comma form) now works alongside the repeated-flag form.

Verification

• typecheck clean; npm test: 1829 tests, 1828 pass, 0 fail, 1 pre-existing skip; npm run build:types clean.
• Smoke: walkthrough_picker_to_first_query*, claude_attach_detach, daemon_foreground_start_stop, plugin_install_local_dir, backfill_codex_fixture, cache_lifecycle_maintenance, mcp_stdio_tools, status_diagnostics, remote_oidc_login.

* walkthrough_picker_to_first_query and walkthrough_to_first_query fail identically on master (pre-existing, reproducible back to v1.10.0: "real hyp init attach exited 0 → 1" / an ai_gateway_messages sql row assertion). With the unrelated assertion locally relaxed, the walkthrough flow passes end-to-end including this PR's new picker span assertions. Worth picking up with Option D (smoke suite).

[platypii]

Code review — CLI cleanup

Overall: clean, low-risk refactor. The bulk is a verbatim code move (core_commands.js → per-topic modules) plus an argv-parser migration onto the shared parseCommandArgv codec and helper dedup. Verified:

• npm run typecheck passes clean → no broken imports, lost exports, or .d.ts-rename fallout.
• All CLI-related tests pass (2043); full suite green.
• The collectivus→hypaware type-file rename is complete (only 3 intentionally-untouched links inside tombstoned LLPs remain).
• Consolidated helpers originOf (ex-safeOrigin), isPlainObject (ex-isObject), and copyDir are byte-identical to what they replaced; the moved command bodies are verbatim.

The migration is faithful on the parts that matter: help-branch ordering ('help' in parsed before !parsed.ok), hyphenated-key reads (no typos), short aliases (-y/-f) wired, and every mutual-exclusion/cross-check rule preserved.

The findings below are all low-severity edge behaviors — none is caught failing by the suite, none is a common input.

Findings

1. readAllStdin now decodes per-chunk, corrupting multibyte UTF-8 split across chunk boundaries — src/core/cli/stdio.js:17
The old remote_commands.js copy accumulated Buffers then Buffer.concat(...).toString('utf8'); the new shared helper does out += chunk.toString('utf8') per chunk. A multibyte codepoint (emoji/CJK/accented) straddling a ~64 KB stream chunk boundary decodes to U+FFFD. Live callers (hyp remote login static token, enrollCentralSink join token) .trim() an ASCII token, so real impact is ~nil — but it's a silent regression in a generic helper. Cheap fix: keep the buffer-concat form.

2. hyp init --retention-days changed from parseInt to strict integer coercion — src/core/commands/init.js:402
Old init used Number.parseInt(value, 10); the schema now uses { type: 'integer' }. Divergences: --retention-days 30.5 was accepted as 30, now errors (exit 2); --retention-days 1e3 was 1, now silently 1000. Note also that backfill.js kept type: 'number' for the same flag, so init and backfill now coerce --retention-days differently. Stricter is arguably better, but it's a behavior change on a script-facing flag worth a conscious call.

3. -h/--help anywhere in argv is reinterpreted as help, across all migrated commands — src/core/cli/verb_codec.js:222
parseCommandArgv scans the whole argv for -h/--help before parsing, so a flag value equal to those strings can no longer be passed literally: hyp join <url> --token-file -h, hyp daemon install --config -h, hyp config validate --path -h now print usage instead of using -h as the value (old parsers took it literally). Extremely unlikely inputs, but a genuine cross-cutting change in the shared wrapper.

4. Greedy array positional doesn't trim or skip empty tokens, unlike the flag form — src/core/cli/verb_codec.js:409
The new greedy-array branch in bindPositionals collects each remaining token raw, while the comma/flag array path (coerceValue, line ~367) does p.trim() + if (!p) continue. So hyp backfill claude "" codex yields ['claude','','codex'] (an empty provider name flows downstream), whereas --providers=claude,,codex yields ['claude','codex']. Same logical input, different result depending on form.

5. parseMcpArgv lost its export — src/core/commands/mcp.js:93
It was exported from core_commands.js in master, now module-private. No in-tree importer, so nothing breaks — flagging only because it's the one old export with no re-export replacement (out-of-tree consumers would break).

Minor / non-blocking notes

• Several rejection messages changed wording without changing exit codes (backfill plan --since lost its targeted "not valid on plan" message → generic "unknown flag"; hyp leave foo, hyp mcp --remote --http, etc.). Cosmetic unless something pins stderr text — no in-repo test does.
• Pre-existing (not caused by this PR): the MCP path validateToolArguments still doesn't enforce items.enum on array args, so the enum-propagation added to the CLI paths here widens a CLI/MCP asymmetry. Latent — no current MCP-exposed schema uses items.enum.

None of these block merge. #1 is the only one I'd actually fix before merging (one-line revert to buffer-concat); the rest are judgment calls you may prefer as-is.

[platypii]

Addressed top issue, merging.