Uh oh!
There was an error while loading. Please reload this page.
Refactor: Remove bootstrap, adopt semantic tokens, and improve Mantine UI usage - #1347
Conversation
- Updated button colors and variants across ClickhousePage, DBChartPage, and DBSearchPage for better visual consistency. - Refined ActionIcon styles in ThemeWrapper to enhance default and subtle variants. - Adjusted background and border colors in various components to align with new semantic color variables. - Replaced hardcoded colors with CSS variables for better theme management in stylesheets. - Removed deprecated design tokens and introduced new semantic color definitions for dark and light modes. - Added custom utility classes for layout and spacing to supplement Bootstrap utilities. - Cleaned up unused styles and variables to streamline the codebase.
- Added muted variant styles for Card and Paper components in ThemeWrapper. - Removed color prop from multiple Text and Button components to use default theme colors. - Updated background colors in various components to use new color variables. - Refactored styles in Table and LogTable modules for consistency with new color scheme. - Removed unused color classes and variables to streamline styles. - Enhanced hover effects for buttons and text elements for better UX.
…variables; update styles for consistency across the application; enhance accessibility by adjusting text properties; modify button variants for improved UI/UX; streamline form elements and layout for better responsiveness; clean up unused imports and redundant code; ensure uniformity in text sizes and colors throughout the application.
…lean up related code; replace NavHoverDropdown with Mantine's Button component; update styles in SessionSidePanel and various SCSS files for consistency and improved theming; delete obsolete variables.scss file.
…t; update related modal handling and styling for consistency
…ructure and improve readability; adjust Badge component usage in AppNavLink for better consistency; update ThemeWrapper to remove default radius for enhanced theming flexibility
…cy; enhance color usage across components; streamline styles for improved theming and accessibility
…d colors; adjust height for improved styling consistency; enhance BreadcrumbNavigation text color for better visibility; implement custom cursor style for table column resizing; modify semantic colors for improved theming and accessibility.
… and maintainability
…with custom implementations for improved consistency and maintainability
🦋 Changeset detectedLatest commit: ecab514 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review: Bootstrap Removal & Mantine Migration✅ Overall AssessmentThis is a well-structured refactor that successfully removes Bootstrap dependencies and migrates to Mantine UI with semantic design tokens. The approach is solid and aligns with modern React/Next.js best practices. Critical IssuesNone found - the PR appears safe to merge from a code quality perspective. Important Observations✅ Strengths:
Testing Recommendations
VerdictApproved - No blocking issues. The minor items noted above can be addressed in follow-up PRs or confirmed as intentional. |
E2E Test Results✅ All tests passed • 39 passed • 3 skipped • 399s
|
…r variable; remove unused color classes for improved clarity and maintainability
… variables for background and border styles; enhance link color based on active state for improved theming and consistency
…aintainability across multiple components
…e bootstrap utilities documentation for clarity
pulpdrew
commented
Nov 14, 2025
Whoops, I missed the edited comment, sorry @elizabetdev. Ripping the band-aid off is OK with me 👍 |
elizabetdev
commented
Nov 14, 2025
teeohhem
commented
Nov 14, 2025
elizabetdev
commented
Nov 14, 2025
@teeohhem I updated the AppNav component to bring it closer to the previous version. The icons on this PR are from Tabler, and a few small UI details were left intentionally (e.g., icon highlight behavior and the beta badge aligned to the right). The beta badge is also using Mantine’s default styling with no overrides, so the text defaults to white. The nav now uses only mantine colors. ![]() |
Uh oh!
There was an error while loading. Please reload this page.
…1384) This was a regression from #1347. This adds back the existing styles. <img width="1210" height="548" alt="Screenshot 2025-11-19 at 9 53 27 AM" src="https://github.com/user-attachments/assets/52343706-2b92-4779-94c0-bdccb1668f09" /> Fixes HDX-2863
…1384) This was a regression from #1347. This adds back the existing styles. <img width="1210" height="548" alt="Screenshot 2025-11-19 at 9 53 27 AM" src="https://github.com/user-attachments/assets/52343706-2b92-4779-94c0-bdccb1668f09" /> Fixes HDX-2863
…lowing into adjacent columns (#2234) ## Summary - Re-add `.text-break`, `.align-top`, `.align-middle`, `.align-bottom` utility classes to `_bootstrap-utilities.scss`. These were referenced by `HDXMultiSeriesTableChart` and `DBRowTable` but dropped during the Bootstrap removal refactor (#1347), leaving wrap mode silently broken. ## Why With `.text-break` undefined, toggling wrap mode on a Table chart cell containing a long URL/identifier without whitespace leaves the cell with only `overflow: hidden` and default `word-break: normal`. The browser can't break the string, partial fragments leak across cell boundaries during fallback rendering, and the visible result is text appearing to overlap into adjacent columns. Reproducible with many narrow columns + URLs like `login.microsoftonline.com/common/oauth2/v2.0/authorize?client_id=…`. ## Test plan - [ ] Build a Table chart over data with long unbreakable strings (URLs, trace IDs, hashes) - [ ] Toggle the wrap-lines icon — long values should break onto multiple lines within their column rather than fragmenting across columns - [ ] Toggle wrap-lines off — truncate-with-ellipsis behavior unchanged - [ ] Existing `DBTableChart.test.tsx` still passes - [ ] Before: <img width="2856" height="460" alt="image" src="https://github.com/user-attachments/assets/c19c0f4e-a445-40e0-b477-592176687281" /> After: <img width="995" height="246" alt="image" src="https://github.com/user-attachments/assets/617923c1-65fd-40e3-85ec-1484d23c4678" /> Ref: HDX-4180



Description
This PR improves the overall design system consistency, theming capabilities, and maintainability of the project by removing Bootstrap dependencies and enhancing Mantine UI usage.
It also serves as step one in preparing the codebase for the future introduction of Click-UI, which will further streamline and unify component usage across the application.
Key Changes
Motivation
Previously, the dark mode was achieved through a global CSS filter, such as:
While this approach provided a quick inversion effect, it had several drawbacks:
By moving to a token-based theme system powered by Mantine, we ensure predictable, maintainable, and accessible theming across all components.
Testing Notes