Uh oh!
There was an error while loading. Please reload this page.
feat: add select primitive with tests - #3
Draft
thejhh wants to merge 1 commit into
Draft
Conversation
thejhh
commented
May 8, 2025
| return nil, fmt.Errorf("select expects exactly 3 arguments (condition, trueValue, falseValue), got %d", len(args)) | ||
| } | ||
| condition := fmt.Sprintf("%v", args[0]) |
ContributorAuthor
There was a problem hiding this comment.
This should be case insensitive
| @@ -0,0 +1,38 @@ | |||
| The `select` operation chooses between two values based on a simple string | |||
ContributorAuthor
There was a problem hiding this comment.
Since we support quite a lot of different types, I think we shouldn't just expect a string.
We should support:
- If an array, empty array is false, otherwise true.
- If null, it is false
- If an empty string, it should be false
- If boolean, a boolean
- Of a function/operation/subroutine, the result of calling it
- If an object, true
- If a promise, we should wait for it and use the result
- ...
We would also need equals and other new primitives
Open
thejhhforce-pushed
the
feature/select-primitive
branch
from
May 9, 2025 17:08
da92051 to
2423c35Comparethejhhforce-pushed
the
feature/select-primitive
branch
6 times, most recently
from
May 19, 2025 09:01
b6db0d4 to
77e32bbCompare
thejhhforce-pushed
the
feature/select-primitive
branch
from
May 19, 2025 09:04
77e32bb to
cff7942Comparethejhh
marked this pull request as draft
May 21, 2025 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.