Allow header

[ajnirp]

#174

[ajnirp]

I couldn't figure out how to get the empty Vec subtest to work. I was getting an assertion fail panic:

(left: `Some(Allow([]))`, right: `Some(Allow([]))`)`

[reem]

Can you rebase this to get rid of the merge commit?

[reem]

you should be able to just use method::Method::..

[ajnirp]

Rebased, also added a bench

[seanmonstar]

This can be just 'self[]' because of Deref.

[seanmonstar]

What test was failing?

[ajnirp]

@seanmonstar I tried to test for an empty vec.

let empty_vec: Vec<Method> = vec![];
let allow = Header::parse_header([b"".to_vec()].as_slice());
assert_eq!(allow, Some(allow(empty_vec)));

which was giving the above-mentioned error. I couldn't figure out what was wrong with this, so I removed the test before pushing.

[seanmonstar]

Could it be that it's parsing "" into Extension("".to_string())?

Can't wait rust-lang/rfcs#504

[ajnirp]

Just checked, that was indeed the problem. Should we include this test, then? (asserting against Extension("".to_string()))

[seanmonstar]

We should have the test that the vec is empty. That it's parsing into an Extension sounds like a bug in http::read_method.

[seanmonstar]

Sorry, wrong place. The bug is here: https://github.com/hyperium/hyper/blob/master/src/method.rs#L82

[ajnirp]

Patched that, and also addressed the fmt_comma_delimited nit.

[seanmonstar]

woo! thanks