Skip to content

Remove stream cargo feature - #2896

Merged
seanmonstar merged 2 commits into
hyperium:masterfrom
oddgrd:remove_stream_cargo_feature
Jun 23, 2022
Merged

Remove stream cargo feature#2896
seanmonstar merged 2 commits into
hyperium:masterfrom
oddgrd:remove_stream_cargo_feature

Conversation

@oddgrd

@oddgrdoddgrd commented Jun 14, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Removes the stream cargo feature and any usage of Stream, including Body::wrap_stream, impl Stream for Body and accept::from_stream.

A few tests were broken, and some examples. Quite extensive changes were needed to fix some of them, which I wasn't able to do in this PR. As discussed on Discord I left TODO comments on the remaining broken tests, tagged with the PR number (#2896).

This PR partially fixes issue #2855.

@oddgrd
oddgrdforce-pushed the remove_stream_cargo_feature branch from ab3d025 to f855b2eCompareJune 14, 2022 20:59
seanmonstar
seanmonstar requested changes Jun 14, 2022
View reviewed changes

@seanmonstarseanmonstar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this issue! (And sorry for not realizing the tests would be annoying to update.) This is pretty close, implementation wise. I left some comments inline about possibly ways to update the tests.

Comment threadexamples/echo.rs Outdated
Comment threadtests/server.rs Outdated
Comment threadsrc/body/body.rs
Comment threadtests/server.rs
Comment threadtests/server.rs
Comment threadtests/client.rs Outdated
Comment threadtests/client.rs
@seanmonstar

seanmonstar commented Jun 15, 2022

Copy link
Copy Markdown
Member

Alright, we merged the StreamBody PR :D

@oddgrd

oddgrd commented Jun 15, 2022

Copy link
Copy Markdown
ContributorAuthor

Awesome, I'll get to work on solving the remaining issues then. :)

@oddgrd
feat(body): remove stream cargo feature
31a8be1
remove stream cargo feature and any usage of stream, as it isn't stable and shouldn't be depended on
closes issue hyperium#2855
@oddgrd
oddgrdforce-pushed the remove_stream_cargo_feature branch from 3fbb3ef to 31a8be1CompareJune 17, 2022 19:41
@seanmonstar
seanmonstar marked this pull request as ready for review June 21, 2022 20:10
@seanmonstar
seanmonstar merged commit ce72f73 into hyperium:masterJun 23, 2022
@oddgrd
oddgrd deleted the remove_stream_cargo_feature branch June 23, 2022 22:16
This was referenced Jun 23, 2022
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanmonstarseanmonstarseanmonstar requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oddgrd@seanmonstar