Uh oh!
There was an error while loading. Please reload this page.
Conversation
ghost
commented
Jul 12, 2022
Hm.... I needed to bump pnet for the tests to pass with strict checks (otherwise you run into uninit memory in there), but that means the MSRV of 1.39 fails tests. And looks like a lot of dependencies depend on the 2021 edition in semver compatible versions with the ones we have in cargo.toml |
ghost
commented
Jul 12, 2022
Also, i'm testing according to the checks that are enabled with I figure it's best to fix all the panics that rust can legally insert now rather than needing to do another backport if/when we get the chance to make |
RalfJung
commented
Jul 12, 2022
Well, the reference says it is UB. |
ghost
commented
Jul 14, 2022
Okay, I tested a few crates ( All 4 compiled and had their tests run fine, even with |
In newer versions of rust, mem::uninitialized and mem::zeroed will panic when they are used for types that don't allow it in more cases. This change allows the tests to run successfully even with the strictest form of the checks.
ghost
commented
Feb 26, 2023
Closing this as not really needed anymore, 0.13 is not maintained and there's no risk of anything actually going wrong even in far future LLVM because of the 0x01 filling. |
Marking this as a draft for now while I test some crates, patching their
hyperversion to be this one then seeing if acargo updatefixes them with strict init checks. The code is done, though.See: #2914