Uh oh!
There was an error while loading. Please reload this page.
Rename body to recv temporarily - #2966
Merged
seanmonstar merged 1 commit intoAug 26, 2022
Merged
Conversation
seanmonstar
commented
Aug 25, 2022
Member
How easy would it be to separate it from the other PR? I suspect this one could merge faster. |
Michael-J-Wardforce-pushed
the
rename-body-to-recv-temporarily
branch
from
August 25, 2022 19:47
5261c37 to
7039392CompareMichael-J-Ward
commented
Aug 25, 2022
ContributorAuthor
I did pop off the commit, I also rebased off of master. on master, this is failing to compile and test. |
Michael-J-Wardforce-pushed
the
rename-body-to-recv-temporarily
branch
from
August 25, 2022 21:10
7039392 to
da70a2eCompareMichael-J-Ward
commented
Aug 25, 2022
ContributorAuthor
(forgot to apply |
seanmonstar
commented
Aug 25, 2022
Member
Looks like the last piece remaining is to remove the link to |
""" We'll eventually want to bikshed the name Recv, but to free up the name Body for hyperium#2839, this can be done quickly. """ Resolvehyperium#2963
Michael-J-Wardforce-pushed
the
rename-body-to-recv-temporarily
branch
from
August 26, 2022 05:08
da70a2e to
c21eebcCompareRajivTS added a commit
to RajivTS/hyper
that referenced
this pull request
Aug 28, 2022
Now that the concrete `Body` type has been temporarily replaced with `Recv` in hyperium#2966, we can rename and export `http_body::Body` as just `Body` instead of `HttpBody`. Closeshyperium#2839
RajivTS added a commit
to RajivTS/hyper
that referenced
this pull request
Aug 29, 2022
Now that the concrete `Body` type has been temporarily replaced with `Recv` in hyperium#2966, we can rename and export `http_body::Body` as just `Body` instead of `HttpBody`. Closeshyperium#2839
seanmonstar pushed a commit
to RajivTS/hyper
that referenced
this pull request
Aug 29, 2022
Now that the concrete `Body` type has been temporarily replaced with `Recv` in hyperium#2966, we can rename and export `http_body::Body` as just `Body` instead of `HttpBody`. Closeshyperium#2839
seanmonstar pushed a commit
that referenced
this pull request
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves#2963
This currently branches off of #2961