Skip to content

feat(rt): replace IO traits with hyper::rt ones - #3230

Merged
seanmonstar merged 1 commit into
masterfrom
io-traits
Jul 10, 2023
Merged

feat(rt): replace IO traits with hyper::rt ones#3230
seanmonstar merged 1 commit into
masterfrom
io-traits

Conversation

@seanmonstar

@seanmonstarseanmonstar commented May 17, 2023

Copy link
Copy Markdown
Member

This replaces the usage of tokio::io::{AsyncRead, AsyncWrite} in hyper's public API with new traits in the hyper::rt module.

Closes#3110

Before merging

  • Determine naming (AsyncRead vs Read; ReadBuf and ReadBufCursor)
  • Determine minimal public methods for ReadBuf and Cursor
  • Document the types and methods
  • Prove that it is forwards-compatible with completion-based IO

@seanmonstar

Copy link
Copy Markdown
MemberAuthor

cc @Noah-Kennedy, regarding making sure it's forwards-compatible.

@Noah-Kennedy

Copy link
Copy Markdown
Contributor

Ping me in a few days if I haven't looked at this

@seanmonstar
seanmonstarforce-pushed the io-traits branch 6 times, most recently from 1b0c922 to 60bc52aCompareJuly 3, 2023 19:08
@seanmonstar
seanmonstarforce-pushed the io-traits branch 2 times, most recently from ab1cad9 to e07f28fCompareJuly 10, 2023 17:28
@seanmonstar
seanmonstar merged commit f9f65b7 into masterJul 10, 2023
@seanmonstar
seanmonstar deleted the io-traits branch July 10, 2023 18:11
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
This replaces the usage of `tokio::io::{AsyncRead, AsyncWrite}` in hyper's public API with new traits in the `hyper::rt` module.
Closeshyperium#3110
BREAKING CHANGE: Any IO transport type provided must not implement `hyper::rt::{Read, Write}` instead of
`tokio::io` traits. You can grab a helper type from `hyper-util` to wrap Tokio types, or implement the traits yourself,
if it's a custom type.
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
This replaces the usage of `tokio::io::{AsyncRead, AsyncWrite}` in hyper's public API with new traits in the `hyper::rt` module.
Closeshyperium#3110
BREAKING CHANGE: Any IO transport type provided must not implement `hyper::rt::{Read, Write}` instead of
`tokio::io` traits. You can grab a helper type from `hyper-util` to wrap Tokio types, or implement the traits yourself,
if it's a custom type.
Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
@jbaum98jbaum98 mentioned this pull request Oct 20, 2024
MadLittleMods added a commit to MadLittleMods/fork-matrix-hyper-federation-client that referenced this pull request Feb 5, 2025
> The free functions `hyper::body::to_bytes` and `aggregate` have been removed. Similar functionality is on `http_body_util::BodyExt::collect`. (0888623d)
>
> https://github.com/hyperium/hyper/blob/master/CHANGELOG.md#v100-rc1-2022-10-25
> remove higher-level `hyper::Client` ([#2941](hyperium/hyper#2941)) (bb3af17c)
>
> https://github.com/hyperium/hyper/blob/master/CHANGELOG.md#v100-rc1-2022-10-25
> remove client::connect module ([#2949](hyperium/hyper#2949)) (5e206883)
>
>
> https://github.com/hyperium/hyper/blob/master/CHANGELOG.md#v100-rc1-2022-10-25
> remove `server::conn::{Http, Connection}` types ([#3013](hyperium/hyper#3013)) (0766d3f7, closes #3012)
>
> https://github.com/hyperium/hyper/blob/master/CHANGELOG.md#v100-rc1-2022-10-25
> The `poll_ready` method has been removed. (fee7d361)
>
> https://github.com/hyperium/hyper/blob/master/CHANGELOG.md#v100-rc1-2022-10-25
> replace IO traits with hyper::rt ones ([#3230](hyperium/hyper#3230)) (f9f65b7a, closes #3110)
>
> https://github.com/hyperium/hyper/blob/master/CHANGELOG.md#v100-rc1-2022-10-25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hyper should use its own IO traits

2 participants

@seanmonstar@Noah-Kennedy