feat: Making the Fabric-X channel configurable - #824
Open
MaryamArif7 wants to merge 6 commits into
Open
MaryamArif7 wants to merge 6 commits into
MaryamArif7 wants to merge 6 commits into
Conversation
Signed-off-by: MaryamArif7 <www.maryamarif28@gmail.com>
MaryamArif7
marked this pull request as draft
September 7, 2026 08:11
Contributor
Author
Contributor
Author
Signed-off-by: MaryamArif7 <www.maryamarif28@gmail.com>
MaryamArif7
marked this pull request as ready for review
September 8, 2026 02:53
umegbewe
reviewed
Sep 15, 2026
umegbewe
reviewed
Sep 15, 2026
Contributor
|
Looks okay, but i'd expect this PR to be modified into something like this in and then render templates from: not from channels[0] and some tests |
Signed-off-by: MaryamArif7 <www.maryamarif28@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




fixes #817
What it does
Fabric-X generation was hardcoding the channel name (
mychannel) instead of reading it fromfablo-config.json. This makes the channel name configurable.Changes
src/setup-docker/templates/fabric-x/scripts/base-functions.sh—configtxgen --channelIDnow uses<%= channels[0].name %>instead of the hardcodedmychannel.src/setup-docker/templates/fabric-x/fxconfig.yaml—channel:field now uses<%= channels[0].name %>instead of the hardcodedmychannel.