chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest by hyperpolymath · Pull Request #44 · hyperpolymath/InvestigativeJournalist.jl

hyperpolymath · 2026-08-05T09:25:48Z

Automated estate top-up. Nothing here invents a value.

Filled — every token with one mechanical answer (owner, repo, forge, author, dates, project name, main branch). Identity from the git remote, dates from the clock, name from the README H1.

Not filled, on purpose — SECURITY_EMAIL (two competing addresses exist in the estate), RESPONSE_TIME, CONDUCT_TEAM (substitutes into "a {{CONDUCT_TEAM}} member", which is not English), WEBSITE, PROJECT_DESCRIPTION, LANG_STACK. More than one defensible answer exists, and a confident wrong value is worse than a visible gap.

Deleted — ARCHITECTURE.md where it is byte-identical to the 346-copy estate boilerplate (blob 607e3d8c). Those 33 lines describe a src/ tests/ docs/ scripts/ config/ tree this repo does not have. Matched by hash, so a genuinely written ARCHITECTURE can never be caught by it.

CODEOWNERS — the solo form from standards/CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all where the only owner is the sole maintainer. templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and resolves standards#55, so it wins. Genuine co-owners (Rule 2) are untouched.

Surfaced — REQUIRES_INITIALISATION.md plus a priority action in 0-AI-MANIFEST.a2ml, listing every remaining token, what it means, which files it belongs in, why it was not done already, and that it is to be deleted only when the work is genuinely complete.

Built from a fresh clone of origin/main, never a local checkout — several of those are dirty and hold unpushed commits.

🤖 Generated with Claude Code

@hyperpolymath

…the rest Estate top-up pass. Three separate things, none of which invents a value. FILLED — every token with a single mechanical answer: OWNER, REPO, FORGE, PROJECT, PACKAGE_NAME, PROJECT_NAME, AUTHOR, AUTHOR_EMAIL, CONDUCT_EMAIL, AUTHOR_FIRST/LAST/INITIALS, CURRENT_YEAR, CURRENT_DATE, DATE, MAIN_BRANCH. Identity comes from the git remote, dates from the clock, project name from the README H1 where there is one. Deliberately NOT filled, because more than one defensible answer exists and a confident wrong value is worse than a visible gap: SECURITY_EMAIL (two competing addresses are in use across the estate), RESPONSE_TIME, CONDUCT_TEAM (which substitutes into "a {{CONDUCT_TEAM}} member", not English), WEBSITE, PROJECT_DESCRIPTION, LANG_STACK. DELETED — ARCHITECTURE.md, where it is byte-identical to the 346-copy estate boilerplate (blob 607e3d8). Those 33 lines describe a src/ tests/ docs/ scripts/ config/ tree that this repo does not have, so the file is not merely uninformative, it is wrong. Genuinely written ARCHITECTURE files are matched by hash and left alone. No file beats a confidently false one. CODEOWNERS — rewritten to the solo form mandated by hyperpolymath/standards CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all line where the only owner is the sole maintainer. The estate's own templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and resolves standards#55, so it wins. Files naming a genuine co-owner are Rule 2 and are untouched. Note @hyperpolymath and @metadatastician are the same person, so a file naming the other account is a copy artifact that silently routed review requests to the wrong account. SURFACED — REQUIRES_INITIALISATION.md, and a priority action in 0-AI-MANIFEST.a2ml. Tokens that need a decision no script can make are left visibly unfilled rather than faked or quietly deleted. The marker says what each one is, which files it belongs in, why it was not done already, and that it must be deleted only once the work is genuinely finished.

gitar-bot · 2026-08-05T09:27:33Z

+;; Copyright (c) 2026 Jonathan D.A. Jewell (hyperpolymath) <j.d.a.jewell@open.ac.uk>
 ;;
-;; Guix channel definition for {{PROJECT_NAME}}
+;; Guix channel definition for Overview


⚠️Bug: Project name mis-derived as "Overview" breaks Guix channel URL
The estate top-up derived the project name from the README's first H1, but that H1 is the section heading # Overview, not the project name (the repo is InvestigativeJournalist.jl). As a result .guix-channel now sets (url "https://github.com/hyperpolymath/Overview") (lines 10 and 17) — a repository that does not exist, so guix pull against this channel will fail. It also contradicts .reuse/dep5 line 4, which correctly keeps Source: https://github.com/hyperpolymath/InvestigativeJournalist.jl. The same wrong value propagates to dep5 Upstream-Name, the Containerfiles, devcontainer.json, .envrc and both Justfiles. Replace "Overview" with the real project/repo name.
Use the actual repository URL so guix pull resolves.:
;; Guix channel definition for InvestigativeJournalist.jl ;; ;; (channel ;; (name 'InvestigativeJournalist) ;; (url "https://github.com/hyperpolymath/InvestigativeJournalist.jl") ;; (branch "main")) ... (url "https://github.com/hyperpolymath/InvestigativeJournalist.jl")
_{Was this helpful? React with 👍 / 👎}

gitar-bot · 2026-08-05T09:27:34Z


 [methodology.state-validation]
-reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"]
+reject-if-contains = ["{{PLACEHOLDER}}", "INVESTIGATIVEJOURNALIST_JL", "rsr-template-repo"]


⚠️Bug: State-validation reject list now rejects the real project name
In methodology.a2ml, reject-if-contains lists template-marker strings that indicate a corrupt/unfilled state file ({{PLACEHOLDER}}, {{PROJECT}}, rsr-template-repo). The top-up substituted the literal template token {{PROJECT}} with INVESTIGATIVEJOURNALIST_JL. This both removes the intended detection of an unfilled {{PROJECT}} placeholder and, worse, causes any legitimate STATE.a2ml that mentions the project's own identifier to be rejected as invalid. This entry should have been excluded from substitution and kept as the literal {{PROJECT}} marker.
Keep the literal placeholder token as a template-detection marker.:
reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"]
_{Was this helpful? React with 👍 / 👎}

gitar-bot · 2026-08-05T09:27:36Z

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

Code Review⚠️ Changes requested0 resolved / 2 findings

Estate top-up fills repository placeholders and drops boilerplate documentation, but the project name mis-derived as 'Overview' breaks the Guix channel URL and causes the state-validation reject list to reject the real project name.

⚠️

Bug: Project name mis-derived as "Overview" breaks Guix channel URL

📄 .guix-channel:4📄 .guix-channel:9📄 .guix-channel:10📄 .guix-channel:17📄 .reuse/dep5:2📄 .reuse/dep5:4📄 .devcontainer/Containerfile:4📄 .devcontainer/Containerfile:6📄 .devcontainer/Containerfile:27📄 .devcontainer/devcontainer.json:4📄 .devcontainer/devcontainer.json:8📄 .envrc:21📄 Justfile:21📄 .machine_readable/contractiles/Justfile:21

The estate top-up derived the project name from the README's first H1, but that H1 is the section heading # Overview, not the project name (the repo is InvestigativeJournalist.jl). As a result .guix-channel now sets (url "https://github.com/hyperpolymath/Overview") (lines 10 and 17) — a repository that does not exist, so guix pull against this channel will fail. It also contradicts .reuse/dep5 line 4, which correctly keeps Source: https://github.com/hyperpolymath/InvestigativeJournalist.jl. The same wrong value propagates to dep5 Upstream-Name, the Containerfiles, devcontainer.json, .envrc and both Justfiles. Replace "Overview" with the real project/repo name.

Use the actual repository URL so `guix pull` resolves.

;; Guix channel definition for InvestigativeJournalist.jl
;;
;; (channel
;; (name 'InvestigativeJournalist)
;; (url "https://github.com/hyperpolymath/InvestigativeJournalist.jl")
;; (branch "main"))
...
(url "https://github.com/hyperpolymath/InvestigativeJournalist.jl")

⚠️

Bug: State-validation reject list now rejects the real project name

📄 .machine_readable/bot_directives/methodology.a2ml:104

In methodology.a2ml, reject-if-contains lists template-marker strings that indicate a corrupt/unfilled state file ({{PLACEHOLDER}}, {{PROJECT}}, rsr-template-repo). The top-up substituted the literal template token {{PROJECT}} with INVESTIGATIVEJOURNALIST_JL. This both removes the intended detection of an unfilled {{PROJECT}} placeholder and, worse, causes any legitimate STATE.a2ml that mentions the project's own identifier to be rejected as invalid. This entry should have been excluded from substitution and kept as the literal {{PROJECT}} marker.

Keep the literal placeholder token as a template-detection marker.

reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"]

🤖 Prompt for agents

Code Review: Estate top-up fills repository placeholders and drops boilerplate documentation, but the project name mis-derived as 'Overview' breaks the Guix channel URL and causes the state-validation reject list to reject the real project name.
1. ⚠️ Bug: Project name mis-derived as "Overview" breaks Guix channel URL
Files: .guix-channel:4, .guix-channel:9, .guix-channel:10, .guix-channel:17, .reuse/dep5:2, .reuse/dep5:4, .devcontainer/Containerfile:4, .devcontainer/Containerfile:6, .devcontainer/Containerfile:27, .devcontainer/devcontainer.json:4, .devcontainer/devcontainer.json:8, .envrc:21, Justfile:21, .machine_readable/contractiles/Justfile:21
The estate top-up derived the project name from the README's first H1, but that H1 is the section heading `# Overview`, not the project name (the repo is InvestigativeJournalist.jl). As a result `.guix-channel` now sets `(url "https://github.com/hyperpolymath/Overview")` (lines 10 and 17) — a repository that does not exist, so `guix pull` against this channel will fail. It also contradicts `.reuse/dep5` line 4, which correctly keeps `Source: https://github.com/hyperpolymath/InvestigativeJournalist.jl`. The same wrong value propagates to `dep5` Upstream-Name, the Containerfiles, devcontainer.json, .envrc and both Justfiles. Replace "Overview" with the real project/repo name.
Fix (Use the actual repository URL so `guix pull` resolves.):
;; Guix channel definition for InvestigativeJournalist.jl
;;
;; (channel
;; (name 'InvestigativeJournalist)
;; (url "https://github.com/hyperpolymath/InvestigativeJournalist.jl")
;; (branch "main"))
...
(url "https://github.com/hyperpolymath/InvestigativeJournalist.jl")
2. ⚠️ Bug: State-validation reject list now rejects the real project name
Files: .machine_readable/bot_directives/methodology.a2ml:104
In `methodology.a2ml`, `reject-if-contains` lists template-marker strings that indicate a corrupt/unfilled state file (`{{PLACEHOLDER}}`, `{{PROJECT}}`, `rsr-template-repo`). The top-up substituted the literal template token `{{PROJECT}}` with `INVESTIGATIVEJOURNALIST_JL`. This both removes the intended detection of an unfilled `{{PROJECT}}` placeholder and, worse, causes any legitimate STATE.a2ml that mentions the project's own identifier to be rejected as invalid. This entry should have been excluded from substitution and kept as the literal `{{PROJECT}}` marker.
Fix (Keep the literal placeholder token as a template-detection marker.):
reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"]

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

`Compact`
`gitar display:verbose`

Important

Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

_{Was this helpful? React with 👍 / 👎 | Gitar}

gitar-bot

⚠️This PR is blocked due to unresolved code review findings.

_{Configure merge blocking · Maintainers can dismiss this review.}

…t a value The estate top-up sweep substituted {{PROJECT}} here along with every other token. This line is a DETECTOR list: the comment above it says these rules detect corrupt/template/stale state files, so the tokens named in it are the ones whose PRESENCE means a state file is broken. Substituting it did two things. It blinded the {{PROJECT}} leak detector, and it made the detector reject any state file containing this repo's own uppercased name — the opposite of what the rule is for. Same failure class as a template recipe rewriting the incident record that documents its own bug: substituting tokens inside a thing that is ABOUT tokens. Nothing else in this PR changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

The previous commit on this branch was written by a script that read the file through a shell command substitution. $(...) strips trailing newlines and printf '%s' does not put one back, so the file lost its final newline and the diff showed "\ No newline at end of file". Content is otherwise byte-identical to that commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

hyperpolymath · 2026-08-06T22:12:11Z

Closing in favour of a reworked substituter — hyperpolymath/standards#590.

This sweep filled {{TOKEN}} placeholders by plain text replacement across every file. Across the 90 repositories reviewed it drew 141 findings, and one is severe:

sed "s/{{PROJECT_NAME}}/$name/g" → sed "s/Conative Gating/$name/g"
sed -e "s/{{DATE}}/$DATE/g" → sed -e "s/2026-08-05/$DATE/g"

Those are the scripts whose job is to perform template substitution. Filling the left-hand side of their own sed expressions means template application silently stops working — and the breakage stays invisible until someone mints a repository from the template and gets a half-substituted tree.

Four further shapes came out of the same cause:

release.sh no longer substitutes {{DATE}} into release notes
just's own {{ARGS}} reported as an unfilled token, leaving repos permanently "not initialised"
instructional docs rewritten to "Replace laminar, laminar, {{DEPS}} with actuals"
documentation describing placeholders had its examples filled in

The rule plain replacement cannot express: a placeholder is sometimes a value to fill and sometimes the subject being discussed. standards#590 encodes that distinction and is tested against this exact corruption (9/9, the first three cases reproducing it).

Nothing here is lost — the placeholder filling will be redone with that tool. Closing rather than fixing forward because repairing 289 branches individually would repeat the mistake at the same scale.

gitar-botBot reviewed Aug 5, 2026
View reviewed changes

gitar-botBot requested changes Aug 5, 2026
View reviewed changes

hyperpolymathand others added 2 commits August 5, 2026 14:13

hyperpolymath closed this Aug 6, 2026

Navigation Menu

Uh oh!

chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest - #44

chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest#44
hyperpolymath wants to merge 3 commits into
mainfrom
chore/estate-topup

hyperpolymath commented Aug 5, 2026

Uh oh!

gitar-botBotAug 5, 2026•
edited
Loading

Uh oh!

gitar-botBotAug 5, 2026•
edited
Loading

Uh oh!

gitar-botBot commented Aug 5, 2026

Uh oh!

gitar-botBot left a comment

Uh oh!

hyperpolymath commented Aug 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

hyperpolymath commented Aug 5, 2026

Uh oh!

gitar-botBotAug 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gitar-botBotAug 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gitar-botBot commented Aug 5, 2026

Uh oh!

gitar-botBot left a comment

Choose a reason for hiding this comment

Uh oh!

hyperpolymath commented Aug 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gitar-botBotAug 5, 2026•
edited
Loading

gitar-botBotAug 5, 2026•
edited
Loading