Skip to content

chore(ci): bump governance-reusable pin to standards main - #100

Merged
hyperpolymath merged 1 commit into
mainfrom
chore/bump-governance-pin-to-standards-main
Sep 8, 2026
Merged

chore(ci): bump governance-reusable pin to standards main#100
hyperpolymath merged 1 commit into
mainfrom
chore/bump-governance-pin-to-standards-main

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Pinned revision 84355587 of governance-reusable.yml carries two bugs that make Governance red on every consumer:

  1. Workflow security linter runs bash scripts/update-actions-lock.sh --verify-local in the caller's checkout, where the script does not exist — exit 127.
  2. Allowlist Preflight runs check-actions-policy.sh with an empty GH_TOKENgh refuses, exit 3.

Both are cured on standards main (fad242d35291de1898242d6737ba02b74a59a2f2): the verifier is copied into \$RUNNER_TEMP, and the policy step is skipped when no credential is supplied.

Witness: verified green on hyperpolymath/blocky-writer#55 at this exact SHA — governance run completed/success, 15/15 jobs, including the two jobs that were red on that repo's default branch.

Judge this PR by the set difference against your own default branch (which governance jobs are newly red), not by overall check colour — unrelated build failures may pre-date it.

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com

The pinned revision carries bugs that make Governance red on every
consumer: the Workflow security linter runs update-actions-lock.sh from
the CALLER's checkout where it does not exist (exit 127), and Allowlist
Preflight runs check-actions-policy.sh with an empty GH_TOKEN (exit 3).

Both are fixed on standards main. Witnessed green on hyperpolymath/blocky-writer
at this exact SHA: governance run completed/success, 15/15 jobs.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 7, 2026

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 02407ac3-f690-43d4-b6e8-10576fadc21e

📥 Commits

Reviewing files that changed from the base of the PR and between 1732eaf and 4ebf64f.

📒 Files selected for processing (1)
  • .github/workflows/governance.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (10)
  • GitHub Check: Deposit findings for gitbot-fleet
  • GitHub Check: Dogfooding compliance summary
  • GitHub Check: scan / Hypatia Neurosymbolic Analysis
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: analyze (actions, none)
⚠️ CI failures not shown inline (2)

GitHub Actions: Workflow Security Linter / 0_lint-workflows.txt: chore(ci): bump governance-reusable pin to standards main

Conclusion: failure

View job details

##[group]Run echo "=== Checking Action Pinning ==="
 �[36;1mecho "=== Checking Action Pinning ==="�[0m
 �[36;1m# Find any uses: lines that don't have `@SHA` format�[0m
 �[36;1m# Pattern: uses: owner/repo@<40-char-hex>�[0m
 �[36;1munpinned=$(grep -rnE "^[[:space:]]+uses:" .github/workflows/ | \�[0m
 �[36;1m  grep -v "@[a-f0-9]\{40\}" | \�[0m
 �[36;1m  grep -v "uses: \./\|uses: docker://\|uses: actions/github-script" || true)�[0m
 �[36;1m�[0m
 �[36;1mif [ -n "$unpinned" ]; then�[0m
 �[36;1m  echo "ERROR: Found unpinned actions:"�[0m
 �[36;1m  echo "$unpinned"�[0m
 �[36;1m  echo ""�[0m
 �[36;1m  echo "Replace version tags with SHA pins, e.g.:"�[0m
 �[36;1m  echo "  uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.1"�[0m
 �[36;1m  exit 1�[0m
 �[36;1mfi�[0m
 �[36;1mecho "All actions are SHA-pinned"�[0m
 shell: /usr/bin/bash -e {0}
 ##[endgroup]
 === Checking Action Pinning ===
 ERROR: Found unpinned actions:
 .github/workflows/push-email-notify.yml:43:        uses: hyperpolymath/smtp-notify-action@v0.2.0 # NOSONAR — pin authority is actions.lock (sha1-ede1191ef6ff3ac02c4f4d9efdf837ee517e11d7)
 .github/workflows/release.yml:120:        uses: actions/upload-artifact@v4.6.2
 .github/workflows/release.yml:143:        uses: softprops/action-gh-release@v2.5.0
 .github/workflows/boj-build.yml:30:        uses: actions/checkout@v6.0.2
 .github/workflows/dependabot-automerge.yml:59:        uses: dependabot/fetch-metadata@v2.2.0
 .github/workflows/quality.yml:33:        uses: trufflesecurity/trufflehog@v3.93.8
 .github/workflows/quality.yml:50:        uses: editorconfig-checker/action-editorconfig-checker@v2.1.0
 .github/workflows/codeql.yml:43:        uses: actions/checkout@v6.0.2
 .github/workflows/codeql.yml:46:        uses: github/codeql-action/init@v4.34.0
 .github/workflows/codeql.yml:52:        uses: github/codeql-action/analyze@v4.34.0
 .github/workflows/instant-sync.yml:34:        uses: peter-evans/repository-dispatch@v4.0.1
 .github/workflows/action...

GitHub Actions: Workflow Security Linter / lint-workflows: chore(ci): bump governance-reusable pin to standards main

Conclusion: failure

View job details

##[group]Run echo "=== Checking Action Pinning ==="
 �[36;1mecho "=== Checking Action Pinning ==="�[0m
 �[36;1m# Find any uses: lines that don't have `@SHA` format�[0m
 �[36;1m# Pattern: uses: owner/repo@<40-char-hex>�[0m
 �[36;1munpinned=$(grep -rnE "^[[:space:]]+uses:" .github/workflows/ | \�[0m
 �[36;1m  grep -v "@[a-f0-9]\{40\}" | \�[0m
 �[36;1m  grep -v "uses: \./\|uses: docker://\|uses: actions/github-script" || true)�[0m
 �[36;1m�[0m
 �[36;1mif [ -n "$unpinned" ]; then�[0m
 �[36;1m  echo "ERROR: Found unpinned actions:"�[0m
 �[36;1m  echo "$unpinned"�[0m
 �[36;1m  echo ""�[0m
 �[36;1m  echo "Replace version tags with SHA pins, e.g.:"�[0m
 �[36;1m  echo "  uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.1"�[0m
 �[36;1m  exit 1�[0m
 �[36;1mfi�[0m
 �[36;1mecho "All actions are SHA-pinned"�[0m
 shell: /usr/bin/bash -e {0}
 ##[endgroup]
 === Checking Action Pinning ===
 ERROR: Found unpinned actions:
 .github/workflows/push-email-notify.yml:43:        uses: hyperpolymath/smtp-notify-action@v0.2.0 # NOSONAR — pin authority is actions.lock (sha1-ede1191ef6ff3ac02c4f4d9efdf837ee517e11d7)
 .github/workflows/release.yml:120:        uses: actions/upload-artifact@v4.6.2
 .github/workflows/release.yml:143:        uses: softprops/action-gh-release@v2.5.0
 .github/workflows/boj-build.yml:30:        uses: actions/checkout@v6.0.2
 .github/workflows/dependabot-automerge.yml:59:        uses: dependabot/fetch-metadata@v2.2.0
 .github/workflows/quality.yml:33:        uses: trufflesecurity/trufflehog@v3.93.8
 .github/workflows/quality.yml:50:        uses: editorconfig-checker/action-editorconfig-checker@v2.1.0
 .github/workflows/codeql.yml:43:        uses: actions/checkout@v6.0.2
 .github/workflows/codeql.yml:46:        uses: github/codeql-action/init@v4.34.0
 .github/workflows/codeql.yml:52:        uses: github/codeql-action/analyze@v4.34.0
 .github/workflows/instant-sync.yml:34:        uses: peter-evans/repository-dispatch@v4.0.1
 .github/workflows/action...
🔇 Additional comments (1)
.github/workflows/governance.yml (1)

18-18: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the governance workflow reference to use a newer verified revision.

Walkthrough

The governance job now pins the reusable governance workflow to commit fad242d35291de1898242d6737ba02b74a59a2f2.

Changes

Cohort / File(s) Summary
Governance workflow
.github/workflows/governance.yml
Updates the pinned reusable governance workflow commit.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4ebf6

The governance workflow now uses the updated pinned reusable workflow revision, with no remaining merge-readiness risk identified.

Poem

A rabbit checks the workflow line
One commit hops into place
Governance follows the new pin
The action path stays clear
Ears up, the checks begin

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating the pinned governance reusable workflow revision.
Description check ✅ Passed The description explains the change, identifies the two failures it addresses, provides the target revision, and includes verification evidence. It does not reproduce all template headings or checklis…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 43ab1fa into main Sep 8, 2026
44 of 47 checks passed
@hyperpolymath
hyperpolymath deleted the chore/bump-governance-pin-to-standards-main branch September 8, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant